Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gitlaboauth: Allow configuring a different api scope #26152

Merged
merged 5 commits into from Oct 18, 2021
Merged

gitlaboauth: Allow configuring a different api scope #26152

merged 5 commits into from Oct 18, 2021

Conversation

ryanslade
Copy link
Contributor

@ryanslade ryanslade commented Oct 15, 2021 •
edited

This change adds the ApiScope field to the GitLabAuthProvider which
enables changing the default scope from api to read_api.

Fixes: https://github.com/sourcegraph/customer/issues/513

@ryanslade
gitlaboauth: Allow configuring a different api scope
54b47de 
This change adds the ApiScope field to the GitLabAuthProvider which
enables changing the default scope from `api` to `read_api`.
@cla-bot cla-bot bot added the cla-signed label Oct 15, 2021
@ryanslade ryanslade requested review from a team and asdine October 15, 2021 14:29
@ryanslade ryanslade marked this pull request as ready for review October 15, 2021 14:32
@sourcegraph-bot
Copy link
Contributor

sourcegraph-bot commented Oct 15, 2021 •
edited

Notifying subscribers in CODENOTIFY files for diff c73fa70...2ef2dc0.

Notify File(s)
@unknwon enterprise/cmd/frontend/internal/auth/gitlaboauth/config_test.go
enterprise/cmd/frontend/internal/auth/gitlaboauth/provider.go

unknwon
unknwon approved these changes Oct 18, 2021
View reviewed changes
schema/site.schema.json Outdated Show resolved Hide resolved
ryanslade and others added 2 commits October 18, 2021 10:19
@ryanslade @unknwon
Update schema/site.schema.json
db36d02 
Co-authored-by: Joe Chen <joe@sourcegraph.com>
@ryanslade
Run generate
2ef2dc0
@ryanslade ryanslade merged commit 1f85617 into main Oct 18, 2021
@ryanslade ryanslade deleted the gitlab-configurable-scope branch October 18, 2021 09:32
@sourcegraph-bot sourcegraph-bot mentioned this pull request Dec 5, 2021
Closed
5 tasks
@sourcegraph-bot sourcegraph-bot mentioned this pull request Mar 8, 2022
Closed
34 tasks
@sourcegraph-bot sourcegraph-bot mentioned this pull request Mar 23, 2022
Closed
5 tasks
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@unknwon unknwon unknwon approved these changes

@asdine asdine Awaiting requested review from asdine

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ryanslade @sourcegraph-bot @unknwon