-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
codeintel: add dashboard for precide-code-intel-worker total in-progress upload size #39690
Conversation
Codenotify: Notifying subscribers in CODENOTIFY files for diff 9d12958...54d3ef4.
|
enterprise/cmd/precise-code-intel-worker/internal/worker/handler.go
Outdated
Show resolved
Hide resolved
enterprise/cmd/precise-code-intel-worker/internal/worker/handler.go
Outdated
Show resolved
Hide resolved
enterprise/cmd/precise-code-intel-worker/internal/worker/handler.go
Outdated
Show resolved
Hide resolved
enterprise/cmd/precise-code-intel-worker/internal/worker/handler.go
Outdated
Show resolved
Hide resolved
f4183f5
to
7903aaa
Compare
gzipSize := h.getUploadSize(upload.UploadSize) | ||
atomic.AddInt64(&h.budgetRemaining, -gzipSize) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we use the uncompressed size for the budget instead in the future?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ultimately yea I think so
enterprise/cmd/frontend/internal/codeintel/httpapi/upload_handler_state.go
Outdated
Show resolved
Hide resolved
Co-authored-by: Eric Fritz <eric@eric-fritz.com>
5190597
to
abf19fa
Compare
Introduces a new panel in the precise-code-intel-worker dashboard for tracking the total in-progress uploads per-instance. This may help us in tracking correlation between in-progress uploads' size and resource usage for better instance sizing.
Follows on from @rafax:
I think the guidance was "precise-code-intel-worker needs more than 3x the size of largest LSIF upload", but we don't have a metric that shows the size of attempted uploads - adding a metric for this would be useful.
Test plan
Tested locally, see picture:
TODO: see if theres any unit tests we can add