Cody: Fix button border display issue & update webview UI toolkit #51726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abeatrix
changed the title
Bundle size report 馃摝
Look at the Statoscope report for a full comparison between the commits 59ae904 and 7cf2a50 or learn more. Open explanation
|
|
The focus border is new 馃憖 
|
philipp-spiess
approved these changes
May 10, 2023
Hardest part was to reload VS Code 馃ぃ Going to remove the focus border, thanks again for catching that <3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #51719
Unblock #51246
Thanks @eseliger and @philipp-spiess for the help with upgrading the packages 馃檱
Issues
There was an issue with VS Code Webview buttons displaying a light border due to max-width set to 300 in the upstream package, which was then fixed in microsoft/vscode-webview-ui-toolkit#384
Text is squeezed to the side due to max width issue:
Fixs
After updating the package, there is still a border for the height, but the width constrain has been removed which solve the issue where the text is squeezed to the side:
Overriding the border color manually worked:
Test plan
Package updated and working fine locally. See screenshots above