Cody VSCode: Add support for verified email check message when connected to app; and improve connected status message #52075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marekweb
changed the title
marekweb
changed the title
marekweb
commented
May 17, 2023
| serverEndpoint: DOTCOM_URL.href, | ||
| serverEndpoint, |
There was a problem hiding this comment.
This fixes a regression; serverEndpoint is already set above to DOTCOM_URL if we're connecting to dotcom, or it's set to LOCAL_APP_URL if we're connecting to App so we don't want to overwrite it here.
|
Is there a setting i'd need to change to test? I have the old feature flag set and app opened, but I don't see the button to login with app: |
abeatrix
approved these changes
May 17, 2023
slimsag
approved these changes
May 17, 2023
limitedmage
reviewed
May 17, 2023
|
@limitedmage yup, makes sense: #52131 |
mrnugget
added a commit
that referenced
this pull request
May 19, 2023
…graph.com" (#52131) Follow-up to this comment: #52075 (review) ## Test plan - N/A
VolhaBakanouskaya
pushed a commit
to VolhaBakanouskaya/sourcegraph-public
that referenced
this pull request
Jun 30, 2023
…graph.com" (#52131) Follow-up to this comment: sourcegraph/sourcegraph#52075 (review) ## Test plan - N/A
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Show verified email message when connecting Cody extension to App
When connecting the Cody extension to App, it's expected to act similarly to dotcom in that requires an email address and if the user doesn't have a verified email address, it should show the same message.
This PR checks if we are connecting to App, and if so it will treat the email verification logic the same as if we were connecting to sourcegraph.com, so we also get the same error message for an unverified email.
Background info: App will basically proxy the request to dotcom so the response to
currentUser { id, hasVerifiedEmail }will be similar to a dotcom response. The only difference, then, is that Cody extension holds an access token to App and App holds an access token to dotcom.Video
Screen.Recording.2023-05-17.at.11.16.53.AM.mov
Update "Connected to" display
This is a cosmetic change to show "Connected to Sourcegraph App" instead of "Connected to http://localhost:3080":
Test plan