Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cody: vsce fix auto-scrolling and update loading page #53976

Closed
wants to merge 1 commit into from

Conversation

abeatrix
Copy link
Contributor

@abeatrix abeatrix commented Jun 22, 2023

This PR updates our Loading Page to be more align with our new design.

Before After
current_loading loading

auto scroll still WIP

Test plan

See image above.

@cla-bot cla-bot bot added the cla-signed label Jun 22, 2023
@abeatrix abeatrix requested a review from toolmantim June 22, 2023 16:42
@sourcegraph-bot
Copy link
Contributor

📖 Storybook live preview

@abeatrix abeatrix changed the title cody: update vs code loading page cody: vsce fix auto-scrolling and update loading page Jun 22, 2023
@toolmantim
Copy link
Contributor

Oh amazing! Mind if I fully port my animation across to it in this PR? Can do it today…

@abeatrix
Copy link
Contributor Author

Yea go crazy on this! The auto scrolling doesn't work yet so you can just remove that change and add yours if you want 😃

@umpox
Copy link
Contributor

umpox commented Jun 26, 2023

@abeatrix I actually already started looking at this (the scrolling issue - we already have an issue here): #53641

The solution is not quite as simple as just removing that line, that was added to ensure that clicking a transcript item in history will always scroll to the bottom.

My proposed fix is to change how we pass transcript around to always ensure it is created with a unique ID. We already set this, we just don't use it (we kinda pass an empty array first and then update that with a real Transcript array when created after the first render).

My PR is here: #54139

Would appreciate your 👀 on this solution, maybe I have missed something

@abeatrix
Copy link
Contributor Author

@umpox the auto scrolling was still WIP so you can ignore this PR. I have also moved the loading screen to a new PR so closing this PR

@abeatrix abeatrix closed this Jun 26, 2023
@abeatrix abeatrix deleted the bee/cody-ui branch June 26, 2023 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants