cody: fix sign in issues with App

[abeatrix]

Close #54045
Moved from #54063

This PR solves connection issues with App where:

1. can’t log out and get back in without access token
2. can't log in if you have VS Code open first, before installing app

App team has confirmed the changes in this PR fixed the issue: (slack thread 1, slack thread 2, slack thread 3)

Auth View Loading Issue - moving to a new PR

Notice we were setting authStatus on config change, which would first pick up the default config when the view is first loaded.

Update to send authStatus with config file via the publishConfig function, which gets trigger on every config change, and the login function also triggers it since the login function also updates the user config. this one we can make sure the config call would have the latest info.

Here you can see the call stack where login would be called before config change

update

i found that i broke the last PR by accidentally removed (!view), where vscodeAPI.postMessage({ command: 'initialized' }) gets called repeatedly 😭

        if (!view) {
            vscodeAPI.postMessage({ command: 'initialized' })
        }

Test plan

Here is a video of how the changes would look:

Code.-.Extension.Development.Host.Welcome.-.23.June.2023.mp4

[sourcegraph-bot]

📖 Storybook live preview

[toolmantim]

@abeatrix just pushed some fixes for the Storybook renders, and approved them on Chromatic ✅

[philipp-spiess]

There are still issues for me even after those changes. When i reload VS Code, I’m always logged out 😞

Screen.Recording.2023-06-26.at.11.37.28.mov

[philipp-spiess]

Noticed something else on main (might be fixed on your PR but I want to write it down regardless):

When I reload VS Code, Cody always shows up on the sidebar, even if I had another sidebar view active before.

[toolmantim]

I'm experiencing a similar bug to @philipp-spiess, where the login page will flash still… but it's usually when you reload from the file explorer or other places. If you reload with Cody focused, I always see the nicer loading animation and chat view. Here is reloading the window from the file explorer, and reloading from Cody chat:

Screen.Recording.2023-06-26.at.11.18.59.pm.mov

I don't think I'm experiencing a full logout though, but it does seem to show the "Download Cody" button on reload if I log into another endpoint, requiring you to use "Switch Account":

Screen.Recording.2023-06-26.at.11.26.52.pm.mov

Repro steps:

• Login to sourcegraph.com
• Reload the window
• See "Download Cody" button
• Choose "Switch Account" and click on the "current" (which should be https://sourcegraph.com/)
• See the logged in chat

[abeatrix]

Hmm the logout issue is weird I don't think I've run into that before.
@philipp-spiess Can you check if you have a different Endpoint set in your workspace settings?
@toolmantim ill take a look at this thanks for testing!

[philipp-spiess]

@abeatrix My user config has

  "cody.serverEndpoint": "https://sourcegraph.com/",

But I also picked the dotcom login in the dropdown list I think

[abeatrix]

@toolmantim @philipp-spiess the app team has confirmed the changes in this PR solved the sign in issues with App (slack thread 1, slack thread 2, slack thread 3), so I'm going to merge this PR and open a new PR for the loading issue.

[abeatrix]

Here is the latest demo of the sign in flow using the last commit from this branch: https://www.loom.com/share/9a3be7ebff0248748522da1c3bc5b3df?sid=b755b69b-7ede-424d-b9d0-b966991a9b1f