Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cody: Add warning message for recipes #54025

Merged
merged 2 commits into from
Jun 26, 2023

Conversation

deepak2431
Copy link
Contributor

This PR closes #53920

Changes made:

  1. Added warning message for each long truncated text
  2. Fixed the args of token length for some of the recipes

Test plan

Tested manually for long code snippets.

@cla-bot cla-bot bot added the cla-signed label Jun 23, 2023
@deepak2431 deepak2431 changed the title Cody: Add warning mmessage for recipes Cody: Add warning message for recipes Jun 23, 2023
@deepak2431
Copy link
Contributor Author

@philipp-spiess @abeatrix Can I have a review please?

Copy link
Contributor

@philipp-spiess philipp-spiess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice LGTM

@philipp-spiess philipp-spiess merged commit e40e0d0 into sourcegraph:main Jun 26, 2023
20 of 21 checks passed
philipp-spiess added a commit that referenced this pull request Jun 27, 2023
philipp-spiess added a commit that referenced this pull request Jun 27, 2023
This reverts commit e40e0d0 (cc
@deepak2431)

We noticed that there is some unexpected behavior in some recipes where
this warning is shown even if only 5 lines of code are selected. It's
probably because the context lines are truncated but we don't have time
to look into this and fix it just yet (we were supposed to release a few
hours ago 😓). We'll take a closer look after the release.

## Test plan

- It's a revert

<!-- All pull requests REQUIRE a test plan:
https://docs.sourcegraph.com/dev/background-information/testing_principles
-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cody: Running recipies with a huge selection truncates without the user being aware of it
2 participants