Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Cody: Add warning message for recipes (#54025)" #54319

Merged
merged 1 commit into from
Jun 27, 2023

Conversation

philipp-spiess
Copy link
Contributor

This reverts commit e40e0d0 (cc @deepak2431)

We noticed that there is some unexpected behavior in some recipes where this warning is shown even if only 5 lines of code are selected. It's probably because the context lines are truncated but we don't have time to look into this and fix it just yet (we were supposed to release a few hours ago 馃槗). We'll take a closer look after the release.

Test plan

  • It's a revert

@philipp-spiess philipp-spiess requested review from abeatrix and a team June 27, 2023 18:21
@cla-bot cla-bot bot added the cla-signed label Jun 27, 2023
@github-actions github-actions bot added the team/code-exploration Issues owned by the Code Exploration team label Jun 27, 2023
@philipp-spiess philipp-spiess enabled auto-merge (squash) June 27, 2023 18:21
Copy link
Contributor

@abeatrix abeatrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!
for context: currently with this change i am not able to run most of the recipes.

@sourcegraph-bot
Copy link
Contributor

馃摉 Storybook live preview

@deepak2431
Copy link
Contributor

@philipp-spiess I am sorry, I didn't expect this as I tested most recipes after adding the warning message. I will retest again all of the recipes here as I have the branch locally.

@abeatrix Are you not able to run any of the recipes? As for the recipes which show warning messages, you need to cancel that from the window then the recipe will execute in the Chat Window. As VSCode info messages are blocking so once you cancel that, then it will execute.

@philipp-spiess philipp-spiess merged commit af3b8ed into main Jun 27, 2023
19 of 20 checks passed
@philipp-spiess philipp-spiess deleted the ps/revert-54025 branch June 27, 2023 19:07
@deepak2431
Copy link
Contributor

I have tested all the recipes again with text under token size and for the truncated ones. I couldn't reproduce the issue. We can look at this again later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed team/code-exploration Issues owned by the Code Exploration team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants