[Backport 5.3.9104] completions: recover from panics in writeEvent #61755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I timeboxed some time to work out why we call writeEvent once the request is done. My main idea is around request cancellation and the first event being an attribution error. However, I could not nail down an exact cause. Instead this is a change to isolate panics to the request it is happening in rather than taking down the whole process. Test Plan: go test (cherry picked from commit c40b376)
sourcegraph-release-bot
added
team/search-platform
keegancsmith
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I timeboxed some time to work out why we call writeEvent once the request is done. My main idea is around request cancellation and the first event being an attribution error. However, I could not nail down an exact cause. Instead this is a change to isolate panics to the request it is happening in rather than taking down the whole process.
Test Plan: go test
Part of #60439
Backport c40b376 from #61754