Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 5.3.9104] completions: recover from panics in writeEvent #61755

Merged
merged 1 commit into from
Apr 10, 2024
Merged

[Backport 5.3.9104] completions: recover from panics in writeEvent #61755

merged 1 commit into from
Apr 10, 2024

Commits on Apr 10, 2024

  1. completions: recover from panics in writeEvent (#61754) 

    I timeboxed some time to work out why we call writeEvent once the
request is done. My main idea is around request cancellation and the
first event being an attribution error. However, I could not nail down
an exact cause. Instead this is a change to isolate panics to the
request it is happening in rather than taking down the whole process.

Test Plan: go test

(cherry picked from commit c40b376)
    @keegancsmith @github-actions
    keegancsmith authored and github-actions[bot] committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    31fd3db View commit details
    Browse the repository at this point in the history