-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gitserver: grpc: switch clientImplementor to use new dedicated gRPC method for FirstEverCommit #62173
Merged
ggilmore
merged 2 commits into
main
from
04-24-gitserver_grpc_switch_clientimplementor_to_use_grpc_for_firstevercommit
May 1, 2024
Merged
gitserver: grpc: switch clientImplementor to use new dedicated gRPC method for FirstEverCommit #62173
ggilmore
merged 2 commits into
main
from
04-24-gitserver_grpc_switch_clientimplementor_to_use_grpc_for_firstevercommit
May 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
team/product-platform
team/source
Tickets under the purview of Source - the one Source to graph it all
labels
Apr 24, 2024
ggilmore
changed the title
gitserver: grpc: switch clientImplementor to use gRPC for FirstEverCommit
Pull Request Summary
Apr 24, 2024
ggilmore
changed the title
Pull Request Summary
gitserver: grpc: switch clientImplementor to use new dedicated gRPC method for FirstEverCommit
Apr 24, 2024
eseliger
approved these changes
Apr 24, 2024
pjlast
approved these changes
Apr 25, 2024
ggilmore
force-pushed
the
04-24-gitserver_grpc_create_firstevercommit_rpc_method_and_server_implementation
branch
from
April 25, 2024 19:08
1340dfb
to
f6b6171
Compare
ggilmore
force-pushed
the
04-24-gitserver_grpc_switch_clientimplementor_to_use_grpc_for_firstevercommit
branch
from
April 25, 2024 19:09
9ef85ef
to
8ff0aa1
Compare
ggilmore
force-pushed
the
04-24-gitserver_grpc_create_firstevercommit_rpc_method_and_server_implementation
branch
from
April 25, 2024 19:12
f6b6171
to
f858a22
Compare
ggilmore
force-pushed
the
04-24-gitserver_grpc_switch_clientimplementor_to_use_grpc_for_firstevercommit
branch
from
April 25, 2024 19:12
8ff0aa1
to
7f16541
Compare
ggilmore
force-pushed
the
04-24-gitserver_grpc_create_firstevercommit_rpc_method_and_server_implementation
branch
from
April 25, 2024 19:28
f858a22
to
02ec89e
Compare
ggilmore
force-pushed
the
04-24-gitserver_grpc_switch_clientimplementor_to_use_grpc_for_firstevercommit
branch
from
April 25, 2024 19:28
7f16541
to
982582a
Compare
ggilmore
force-pushed
the
04-24-gitserver_grpc_create_firstevercommit_rpc_method_and_server_implementation
branch
from
April 25, 2024 19:35
02ec89e
to
5c223e4
Compare
ggilmore
force-pushed
the
04-24-gitserver_grpc_switch_clientimplementor_to_use_grpc_for_firstevercommit
branch
from
April 25, 2024 19:35
982582a
to
75c9be3
Compare
ggilmore
force-pushed
the
04-24-gitserver_grpc_create_firstevercommit_rpc_method_and_server_implementation
branch
from
April 25, 2024 23:14
5c223e4
to
1f012eb
Compare
ggilmore
force-pushed
the
04-24-gitserver_grpc_switch_clientimplementor_to_use_grpc_for_firstevercommit
branch
from
April 25, 2024 23:14
75c9be3
to
9bb6fe5
Compare
ggilmore
force-pushed
the
04-24-gitserver_grpc_create_firstevercommit_rpc_method_and_server_implementation
branch
from
April 25, 2024 23:16
1f012eb
to
9f0a175
Compare
ggilmore
force-pushed
the
04-24-gitserver_grpc_switch_clientimplementor_to_use_grpc_for_firstevercommit
branch
from
April 25, 2024 23:16
9bb6fe5
to
9b5b1b7
Compare
ggilmore
force-pushed
the
04-24-gitserver_grpc_create_firstevercommit_rpc_method_and_server_implementation
branch
from
April 26, 2024 17:20
9f0a175
to
582385f
Compare
ggilmore
force-pushed
the
04-24-gitserver_grpc_switch_clientimplementor_to_use_grpc_for_firstevercommit
branch
from
April 26, 2024 17:20
9b5b1b7
to
89f6149
Compare
ggilmore
force-pushed
the
04-24-gitserver_grpc_create_firstevercommit_rpc_method_and_server_implementation
branch
from
April 26, 2024 18:59
582385f
to
6c0168e
Compare
ggilmore
force-pushed
the
04-24-gitserver_grpc_switch_clientimplementor_to_use_grpc_for_firstevercommit
branch
from
April 26, 2024 18:59
89f6149
to
4c62a2d
Compare
ggilmore
force-pushed
the
04-24-gitserver_grpc_switch_clientimplementor_to_use_grpc_for_firstevercommit
branch
from
April 30, 2024 05:19
9e83fa2
to
5848e61
Compare
eseliger
approved these changes
Apr 30, 2024
ggilmore
force-pushed
the
04-24-gitserver_grpc_create_firstevercommit_rpc_method_and_server_implementation
branch
from
April 30, 2024 17:03
6543606
to
f258a65
Compare
ggilmore
force-pushed
the
04-24-gitserver_grpc_switch_clientimplementor_to_use_grpc_for_firstevercommit
branch
2 times, most recently
from
April 30, 2024 17:14
e3f21ba
to
1cbf637
Compare
ggilmore
force-pushed
the
04-24-gitserver_grpc_create_firstevercommit_rpc_method_and_server_implementation
branch
from
April 30, 2024 19:21
f258a65
to
f5c873d
Compare
ggilmore
force-pushed
the
04-24-gitserver_grpc_switch_clientimplementor_to_use_grpc_for_firstevercommit
branch
from
April 30, 2024 19:21
1cbf637
to
b52e1ec
Compare
ggilmore
force-pushed
the
04-24-gitserver_grpc_create_firstevercommit_rpc_method_and_server_implementation
branch
from
April 30, 2024 19:22
f5c873d
to
07f51e6
Compare
ggilmore
force-pushed
the
04-24-gitserver_grpc_switch_clientimplementor_to_use_grpc_for_firstevercommit
branch
from
April 30, 2024 19:22
b52e1ec
to
99c6668
Compare
ggilmore
force-pushed
the
04-24-gitserver_grpc_create_firstevercommit_rpc_method_and_server_implementation
branch
from
April 30, 2024 20:06
07f51e6
to
9c9c844
Compare
ggilmore
force-pushed
the
04-24-gitserver_grpc_switch_clientimplementor_to_use_grpc_for_firstevercommit
branch
from
April 30, 2024 20:07
6de4b91
to
d3bef7f
Compare
ggilmore
force-pushed
the
04-24-gitserver_grpc_create_firstevercommit_rpc_method_and_server_implementation
branch
from
April 30, 2024 20:34
9c9c844
to
302550c
Compare
ggilmore
force-pushed
the
04-24-gitserver_grpc_switch_clientimplementor_to_use_grpc_for_firstevercommit
branch
from
April 30, 2024 20:35
d3bef7f
to
0d07353
Compare
ggilmore
force-pushed
the
04-24-gitserver_grpc_create_firstevercommit_rpc_method_and_server_implementation
branch
from
April 30, 2024 22:29
302550c
to
241022e
Compare
ggilmore
force-pushed
the
04-24-gitserver_grpc_switch_clientimplementor_to_use_grpc_for_firstevercommit
branch
from
April 30, 2024 22:30
0d07353
to
bfbeb0f
Compare
ggilmore
force-pushed
the
04-24-gitserver_grpc_create_firstevercommit_rpc_method_and_server_implementation
branch
from
May 1, 2024 04:16
241022e
to
c4f47bf
Compare
Base automatically changed from
04-24-gitserver_grpc_create_firstevercommit_rpc_method_and_server_implementation
to
main
May 1, 2024 04:32
ggilmore
force-pushed
the
04-24-gitserver_grpc_switch_clientimplementor_to_use_grpc_for_firstevercommit
branch
from
May 1, 2024 04:34
bfbeb0f
to
df8113e
Compare
ggilmore
deleted the
04-24-gitserver_grpc_switch_clientimplementor_to_use_grpc_for_firstevercommit
branch
May 1, 2024 04:46
This was referenced May 1, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cla-signed
team/product-platform
team/source
Tickets under the purview of Source - the one Source to graph it all
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #61689
This PR switches the gitserver client implementation to use the new gRPC FirstCommitEver() method introduced in #62169 instead of shoving it through the
exec()
endpoint.Test plan
Unit tests