Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

worker: embeddings: replace usage of old gitserver.DiffSymbols client method with new gitserver.ChangedFiles method #62359

Conversation

ggilmore
Copy link
Contributor

@ggilmore ggilmore commented May 1, 2024

Part of #60654

This PR replaces the worker embedding job's use of the old gitserver.DiffSymbols endpoint with the gitserver.ChangedFiles gRPC endpoint introduced in #62354.

Test plan

Existing CI

Copy link
Contributor Author

ggilmore commented May 1, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ggilmore and the rest of your teammates on Graphite Graphite

@ggilmore ggilmore force-pushed the 05-01-searcher_replace_usage_of_gitserver.diffsymbols_with_new_gitserver.changedfiles_client_method branch from aef2100 to a65df71 Compare May 1, 2024 21:13
@ggilmore ggilmore force-pushed the 05-01-worker_embeddings_replace_usage_of_old_gitserver.diffsymbols_client_method_with_new_gitserver.changedfiles_method branch from a0b217e to 85029be Compare May 1, 2024 21:13
@ggilmore ggilmore force-pushed the 05-01-searcher_replace_usage_of_gitserver.diffsymbols_with_new_gitserver.changedfiles_client_method branch from a65df71 to 37153ff Compare May 1, 2024 21:18
@ggilmore ggilmore force-pushed the 05-01-worker_embeddings_replace_usage_of_old_gitserver.diffsymbols_client_method_with_new_gitserver.changedfiles_method branch from 85029be to 69e4bb9 Compare May 1, 2024 21:18
@ggilmore ggilmore force-pushed the 05-01-searcher_replace_usage_of_gitserver.diffsymbols_with_new_gitserver.changedfiles_client_method branch from 37153ff to eb2fbee Compare May 1, 2024 21:21
@ggilmore ggilmore force-pushed the 05-01-worker_embeddings_replace_usage_of_old_gitserver.diffsymbols_client_method_with_new_gitserver.changedfiles_method branch from 69e4bb9 to aaf73ae Compare May 1, 2024 21:22
@ggilmore ggilmore force-pushed the 05-01-searcher_replace_usage_of_gitserver.diffsymbols_with_new_gitserver.changedfiles_client_method branch from eb2fbee to 6ad30aa Compare May 1, 2024 21:25
@ggilmore ggilmore force-pushed the 05-01-worker_embeddings_replace_usage_of_old_gitserver.diffsymbols_client_method_with_new_gitserver.changedfiles_method branch from aaf73ae to 2c110b4 Compare May 1, 2024 21:25
@ggilmore ggilmore force-pushed the 05-01-searcher_replace_usage_of_gitserver.diffsymbols_with_new_gitserver.changedfiles_client_method branch from 6ad30aa to 944d98c Compare May 1, 2024 21:30
@ggilmore ggilmore force-pushed the 05-01-worker_embeddings_replace_usage_of_old_gitserver.diffsymbols_client_method_with_new_gitserver.changedfiles_method branch from 2c110b4 to 3d38d96 Compare May 1, 2024 21:30
@ggilmore ggilmore force-pushed the 05-01-searcher_replace_usage_of_gitserver.diffsymbols_with_new_gitserver.changedfiles_client_method branch from 944d98c to 47c96dc Compare May 1, 2024 21:53
@ggilmore ggilmore force-pushed the 05-01-worker_embeddings_replace_usage_of_old_gitserver.diffsymbols_client_method_with_new_gitserver.changedfiles_method branch from 3d38d96 to 253343d Compare May 1, 2024 21:53
@ggilmore ggilmore force-pushed the 05-01-worker_embeddings_replace_usage_of_old_gitserver.diffsymbols_client_method_with_new_gitserver.changedfiles_method branch from f63624e to 93a4bc2 Compare May 6, 2024 19:24
@ggilmore ggilmore force-pushed the 05-01-searcher_replace_usage_of_gitserver.diffsymbols_with_new_gitserver.changedfiles_client_method branch from 1327c66 to 69edd2b Compare May 6, 2024 19:38
@ggilmore ggilmore force-pushed the 05-01-worker_embeddings_replace_usage_of_old_gitserver.diffsymbols_client_method_with_new_gitserver.changedfiles_method branch from 93a4bc2 to ffed11d Compare May 6, 2024 19:38
@ggilmore ggilmore force-pushed the 05-01-searcher_replace_usage_of_gitserver.diffsymbols_with_new_gitserver.changedfiles_client_method branch from 69edd2b to 54d0a0b Compare May 6, 2024 21:56
@ggilmore ggilmore force-pushed the 05-01-worker_embeddings_replace_usage_of_old_gitserver.diffsymbols_client_method_with_new_gitserver.changedfiles_method branch from ffed11d to a57255b Compare May 6, 2024 21:56
@ggilmore ggilmore force-pushed the 05-01-searcher_replace_usage_of_gitserver.diffsymbols_with_new_gitserver.changedfiles_client_method branch from 54d0a0b to 13dde62 Compare May 6, 2024 23:28
@ggilmore ggilmore force-pushed the 05-01-worker_embeddings_replace_usage_of_old_gitserver.diffsymbols_client_method_with_new_gitserver.changedfiles_method branch from a57255b to ee202a6 Compare May 6, 2024 23:28
@ggilmore ggilmore force-pushed the 05-01-searcher_replace_usage_of_gitserver.diffsymbols_with_new_gitserver.changedfiles_client_method branch from 13dde62 to 30c4a53 Compare May 6, 2024 23:35
@ggilmore ggilmore force-pushed the 05-01-worker_embeddings_replace_usage_of_old_gitserver.diffsymbols_client_method_with_new_gitserver.changedfiles_method branch from ee202a6 to b5751c2 Compare May 6, 2024 23:35
@ggilmore ggilmore force-pushed the 05-01-searcher_replace_usage_of_gitserver.diffsymbols_with_new_gitserver.changedfiles_client_method branch from 30c4a53 to 47ab090 Compare May 6, 2024 23:50
@ggilmore ggilmore force-pushed the 05-01-worker_embeddings_replace_usage_of_old_gitserver.diffsymbols_client_method_with_new_gitserver.changedfiles_method branch from b5751c2 to bfb8ca5 Compare May 6, 2024 23:50
@ggilmore ggilmore force-pushed the 05-01-searcher_replace_usage_of_gitserver.diffsymbols_with_new_gitserver.changedfiles_client_method branch from 47ab090 to 5573d54 Compare May 7, 2024 03:47
@ggilmore ggilmore force-pushed the 05-01-worker_embeddings_replace_usage_of_old_gitserver.diffsymbols_client_method_with_new_gitserver.changedfiles_method branch from bfb8ca5 to 9554328 Compare May 7, 2024 03:48
@ggilmore ggilmore force-pushed the 05-01-searcher_replace_usage_of_gitserver.diffsymbols_with_new_gitserver.changedfiles_client_method branch from 5573d54 to 3f808d2 Compare May 7, 2024 16:13
@ggilmore ggilmore force-pushed the 05-01-worker_embeddings_replace_usage_of_old_gitserver.diffsymbols_client_method_with_new_gitserver.changedfiles_method branch from 9554328 to 95b8636 Compare May 7, 2024 16:13
@ggilmore ggilmore force-pushed the 05-01-searcher_replace_usage_of_gitserver.diffsymbols_with_new_gitserver.changedfiles_client_method branch from 3f808d2 to 0445a45 Compare May 7, 2024 16:16
@ggilmore ggilmore force-pushed the 05-01-worker_embeddings_replace_usage_of_old_gitserver.diffsymbols_client_method_with_new_gitserver.changedfiles_method branch from 95b8636 to 353136f Compare May 7, 2024 16:16
@ggilmore ggilmore force-pushed the 05-01-searcher_replace_usage_of_gitserver.diffsymbols_with_new_gitserver.changedfiles_client_method branch from 0445a45 to e8a9cb7 Compare May 7, 2024 16:18
@ggilmore ggilmore force-pushed the 05-01-worker_embeddings_replace_usage_of_old_gitserver.diffsymbols_client_method_with_new_gitserver.changedfiles_method branch from 353136f to 425cc8a Compare May 7, 2024 16:18
@ggilmore ggilmore force-pushed the 05-01-searcher_replace_usage_of_gitserver.diffsymbols_with_new_gitserver.changedfiles_client_method branch from e8a9cb7 to 1f8648e Compare May 7, 2024 18:09
Base automatically changed from 05-01-searcher_replace_usage_of_gitserver.diffsymbols_with_new_gitserver.changedfiles_client_method to main May 7, 2024 18:20
… method with new gitserver.ChangedFiles method
@ggilmore ggilmore force-pushed the 05-01-worker_embeddings_replace_usage_of_old_gitserver.diffsymbols_client_method_with_new_gitserver.changedfiles_method branch from 425cc8a to c2000a7 Compare May 7, 2024 18:21
Copy link
Contributor Author

ggilmore commented May 7, 2024

Merge activity

  • May 7, 2:22 PM EDT: Graphite rebased this pull request as part of a merge.
  • May 7, 2:33 PM EDT: @ggilmore merged this pull request with Graphite.

@ggilmore ggilmore merged commit 47d82c7 into main May 7, 2024
13 checks passed
@ggilmore ggilmore deleted the 05-01-worker_embeddings_replace_usage_of_old_gitserver.diffsymbols_client_method_with_new_gitserver.changedfiles_method branch May 7, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed team/product-platform team/source Tickets under the purview of Source - the one Source to graph it all
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants