-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
worker: embeddings: replace usage of old gitserver.DiffSymbols client method with new gitserver.ChangedFiles method #62359
Merged
ggilmore
merged 1 commit into
main
from
05-01-worker_embeddings_replace_usage_of_old_gitserver.diffsymbols_client_method_with_new_gitserver.changedfiles_method
May 7, 2024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
team/product-platform
team/source
Tickets under the purview of Source - the one Source to graph it all
labels
May 1, 2024
This was referenced May 1, 2024
ggilmore
force-pushed
the
05-01-searcher_replace_usage_of_gitserver.diffsymbols_with_new_gitserver.changedfiles_client_method
branch
from
May 1, 2024 21:13
aef2100
to
a65df71
Compare
ggilmore
force-pushed
the
05-01-worker_embeddings_replace_usage_of_old_gitserver.diffsymbols_client_method_with_new_gitserver.changedfiles_method
branch
from
May 1, 2024 21:13
a0b217e
to
85029be
Compare
ggilmore
force-pushed
the
05-01-searcher_replace_usage_of_gitserver.diffsymbols_with_new_gitserver.changedfiles_client_method
branch
from
May 1, 2024 21:18
a65df71
to
37153ff
Compare
ggilmore
force-pushed
the
05-01-worker_embeddings_replace_usage_of_old_gitserver.diffsymbols_client_method_with_new_gitserver.changedfiles_method
branch
from
May 1, 2024 21:18
85029be
to
69e4bb9
Compare
ggilmore
force-pushed
the
05-01-searcher_replace_usage_of_gitserver.diffsymbols_with_new_gitserver.changedfiles_client_method
branch
from
May 1, 2024 21:21
37153ff
to
eb2fbee
Compare
ggilmore
force-pushed
the
05-01-worker_embeddings_replace_usage_of_old_gitserver.diffsymbols_client_method_with_new_gitserver.changedfiles_method
branch
from
May 1, 2024 21:22
69e4bb9
to
aaf73ae
Compare
ggilmore
force-pushed
the
05-01-searcher_replace_usage_of_gitserver.diffsymbols_with_new_gitserver.changedfiles_client_method
branch
from
May 1, 2024 21:25
eb2fbee
to
6ad30aa
Compare
ggilmore
force-pushed
the
05-01-worker_embeddings_replace_usage_of_old_gitserver.diffsymbols_client_method_with_new_gitserver.changedfiles_method
branch
from
May 1, 2024 21:25
aaf73ae
to
2c110b4
Compare
ggilmore
force-pushed
the
05-01-searcher_replace_usage_of_gitserver.diffsymbols_with_new_gitserver.changedfiles_client_method
branch
from
May 1, 2024 21:30
6ad30aa
to
944d98c
Compare
ggilmore
force-pushed
the
05-01-worker_embeddings_replace_usage_of_old_gitserver.diffsymbols_client_method_with_new_gitserver.changedfiles_method
branch
from
May 1, 2024 21:30
2c110b4
to
3d38d96
Compare
ggilmore
force-pushed
the
05-01-searcher_replace_usage_of_gitserver.diffsymbols_with_new_gitserver.changedfiles_client_method
branch
from
May 1, 2024 21:53
944d98c
to
47c96dc
Compare
ggilmore
force-pushed
the
05-01-worker_embeddings_replace_usage_of_old_gitserver.diffsymbols_client_method_with_new_gitserver.changedfiles_method
branch
from
May 1, 2024 21:53
3d38d96
to
253343d
Compare
ggilmore
force-pushed
the
05-01-worker_embeddings_replace_usage_of_old_gitserver.diffsymbols_client_method_with_new_gitserver.changedfiles_method
branch
from
May 6, 2024 19:24
f63624e
to
93a4bc2
Compare
ggilmore
force-pushed
the
05-01-searcher_replace_usage_of_gitserver.diffsymbols_with_new_gitserver.changedfiles_client_method
branch
from
May 6, 2024 19:38
1327c66
to
69edd2b
Compare
ggilmore
force-pushed
the
05-01-worker_embeddings_replace_usage_of_old_gitserver.diffsymbols_client_method_with_new_gitserver.changedfiles_method
branch
from
May 6, 2024 19:38
93a4bc2
to
ffed11d
Compare
eseliger
approved these changes
May 6, 2024
ggilmore
force-pushed
the
05-01-searcher_replace_usage_of_gitserver.diffsymbols_with_new_gitserver.changedfiles_client_method
branch
from
May 6, 2024 21:56
69edd2b
to
54d0a0b
Compare
ggilmore
force-pushed
the
05-01-worker_embeddings_replace_usage_of_old_gitserver.diffsymbols_client_method_with_new_gitserver.changedfiles_method
branch
from
May 6, 2024 21:56
ffed11d
to
a57255b
Compare
ggilmore
force-pushed
the
05-01-searcher_replace_usage_of_gitserver.diffsymbols_with_new_gitserver.changedfiles_client_method
branch
from
May 6, 2024 23:28
54d0a0b
to
13dde62
Compare
ggilmore
force-pushed
the
05-01-worker_embeddings_replace_usage_of_old_gitserver.diffsymbols_client_method_with_new_gitserver.changedfiles_method
branch
from
May 6, 2024 23:28
a57255b
to
ee202a6
Compare
ggilmore
force-pushed
the
05-01-searcher_replace_usage_of_gitserver.diffsymbols_with_new_gitserver.changedfiles_client_method
branch
from
May 6, 2024 23:35
13dde62
to
30c4a53
Compare
ggilmore
force-pushed
the
05-01-worker_embeddings_replace_usage_of_old_gitserver.diffsymbols_client_method_with_new_gitserver.changedfiles_method
branch
from
May 6, 2024 23:35
ee202a6
to
b5751c2
Compare
ggilmore
force-pushed
the
05-01-searcher_replace_usage_of_gitserver.diffsymbols_with_new_gitserver.changedfiles_client_method
branch
from
May 6, 2024 23:50
30c4a53
to
47ab090
Compare
ggilmore
force-pushed
the
05-01-worker_embeddings_replace_usage_of_old_gitserver.diffsymbols_client_method_with_new_gitserver.changedfiles_method
branch
from
May 6, 2024 23:50
b5751c2
to
bfb8ca5
Compare
ggilmore
force-pushed
the
05-01-searcher_replace_usage_of_gitserver.diffsymbols_with_new_gitserver.changedfiles_client_method
branch
from
May 7, 2024 03:47
47ab090
to
5573d54
Compare
ggilmore
force-pushed
the
05-01-worker_embeddings_replace_usage_of_old_gitserver.diffsymbols_client_method_with_new_gitserver.changedfiles_method
branch
from
May 7, 2024 03:48
bfb8ca5
to
9554328
Compare
ggilmore
force-pushed
the
05-01-searcher_replace_usage_of_gitserver.diffsymbols_with_new_gitserver.changedfiles_client_method
branch
from
May 7, 2024 16:13
5573d54
to
3f808d2
Compare
ggilmore
force-pushed
the
05-01-worker_embeddings_replace_usage_of_old_gitserver.diffsymbols_client_method_with_new_gitserver.changedfiles_method
branch
from
May 7, 2024 16:13
9554328
to
95b8636
Compare
ggilmore
force-pushed
the
05-01-searcher_replace_usage_of_gitserver.diffsymbols_with_new_gitserver.changedfiles_client_method
branch
from
May 7, 2024 16:16
3f808d2
to
0445a45
Compare
ggilmore
force-pushed
the
05-01-worker_embeddings_replace_usage_of_old_gitserver.diffsymbols_client_method_with_new_gitserver.changedfiles_method
branch
from
May 7, 2024 16:16
95b8636
to
353136f
Compare
ggilmore
force-pushed
the
05-01-searcher_replace_usage_of_gitserver.diffsymbols_with_new_gitserver.changedfiles_client_method
branch
from
May 7, 2024 16:18
0445a45
to
e8a9cb7
Compare
ggilmore
force-pushed
the
05-01-worker_embeddings_replace_usage_of_old_gitserver.diffsymbols_client_method_with_new_gitserver.changedfiles_method
branch
from
May 7, 2024 16:18
353136f
to
425cc8a
Compare
ggilmore
force-pushed
the
05-01-searcher_replace_usage_of_gitserver.diffsymbols_with_new_gitserver.changedfiles_client_method
branch
from
May 7, 2024 18:09
e8a9cb7
to
1f8648e
Compare
Base automatically changed from
05-01-searcher_replace_usage_of_gitserver.diffsymbols_with_new_gitserver.changedfiles_client_method
to
main
May 7, 2024 18:20
… method with new gitserver.ChangedFiles method
ggilmore
force-pushed
the
05-01-worker_embeddings_replace_usage_of_old_gitserver.diffsymbols_client_method_with_new_gitserver.changedfiles_method
branch
from
May 7, 2024 18:21
425cc8a
to
c2000a7
Compare
ggilmore
deleted the
05-01-worker_embeddings_replace_usage_of_old_gitserver.diffsymbols_client_method_with_new_gitserver.changedfiles_method
branch
May 7, 2024 18:33
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cla-signed
team/product-platform
team/source
Tickets under the purview of Source - the one Source to graph it all
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #60654
This PR replaces the worker embedding job's use of the old gitserver.DiffSymbols endpoint with the gitserver.ChangedFiles gRPC endpoint introduced in #62354.
Test plan
Existing CI