gitserver: Implement CommitsUniqueToBranch using Commits #62513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 8, 2024
github-actions
bot
added
team/product-platform
team/source
eseliger
force-pushed
the
es/ls-tree-grpc-2
branch
from
7a03a1c
to
6454f98
Compare
eseliger
force-pushed
the
es/05-08-gitserverimplementcommitsuniquetobranchusingcommits
branch
from
328eaa6
to
52ad1ff
Compare
This was referenced May 8, 2024
Graphite Automations"Assign Source to gitserver PRs" took an action on this PR • (05/08/24)3 assignees were added to this PR based on Geoffrey Gilmore's automation. |
ggilmore
reviewed
May 8, 2024
ggilmore
approved these changes
May 8, 2024
pjlast
reviewed
May 9, 2024
eseliger
force-pushed
the
es/ls-tree-grpc-2
branch
from
6454f98
to
f2bf72e
Compare
eseliger
force-pushed
the
es/05-08-gitserverimplementcommitsuniquetobranchusingcommits
branch
from
52ad1ff
to
f1f50cb
Compare
eseliger
force-pushed
the
es/ls-tree-grpc-2
branch
2 times, most recently
from
ecd1764
to
6d0b40a
Compare
eseliger
force-pushed
the
es/05-08-gitserverimplementcommitsuniquetobranchusingcommits
branch
from
f1f50cb
to
2bf43b1
Compare
eseliger
force-pushed
the
es/ls-tree-grpc-2
branch
from
6d0b40a
to
0a08be5
Compare
eseliger
force-pushed
the
es/05-08-gitserverimplementcommitsuniquetobranchusingcommits
branch
from
2bf43b1
to
bba7e86
Compare
This was referenced May 10, 2024
eseliger
force-pushed
the
es/ls-tree-grpc-2
branch
from
0a08be5
to
4e1c78e
Compare
eseliger
force-pushed
the
es/05-08-gitserverimplementcommitsuniquetobranchusingcommits
branch
2 times, most recently
from
5cb7b4d
to
e0513d4
Compare
eseliger
force-pushed
the
es/ls-tree-grpc-2
branch
from
4e1c78e
to
4efccd4
Compare
eseliger
force-pushed
the
es/05-08-gitserverimplementcommitsuniquetobranchusingcommits
branch
from
e0513d4
to
0301fe4
Compare
This PR changes the implementation of CommitsUniqueToBranch to use the existing Commits API. The range syntax HEAD..branch is equivalent to `branch ^HEAD` (see git log documentation). Commits also already handles subrepo perms correctly so we don't need to reimplement that in here. We can then stitch together the expected response from that. Test plan: Verified the git command does the same, and the existing unit and E2E tests still pass.
eseliger
force-pushed
the
es/05-08-gitserverimplementcommitsuniquetobranchusingcommits
branch
from
0301fe4
to
c74a757
Compare
eseliger
deleted the
es/05-08-gitserverimplementcommitsuniquetobranchusingcommits
branch
This was referenced May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the implementation of CommitsUniqueToBranch to use the existing Commits API.
The range syntax HEAD..branch is equivalent to
branch ^HEAD(see git log documentation). Commits also already handles subrepo perms correctly so we don't need to reimplement that in here.We can then stitch together the expected response from that.
Test plan:
Verified the git command does the same, and the existing unit and E2E tests still pass.