gitserver: Implement CommitLog using Commits #62518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 8, 2024
github-actions
bot
added
team/product-platform
team/source
This was referenced May 8, 2024
Graphite Automations"Assign Source to gitserver PRs" took an action on this PR • (05/08/24)3 assignees were added to this PR based on Geoffrey Gilmore's automation. |
ggilmore
approved these changes
May 8, 2024
pjlast
approved these changes
May 9, 2024
eseliger
force-pushed
the
es/05-08-gitservermovecommitsuniquetobranchtocallsite
branch
from
ca98456
to
c5a4188
Compare
eseliger
force-pushed
the
es/05-08-gitserverimplementcommitlogusingcommits
branch
from
836e6b2
to
c578d4c
Compare
eseliger
force-pushed
the
es/05-08-gitservermovecommitsuniquetobranchtocallsite
branch
from
c5a4188
to
7d955ac
Compare
eseliger
force-pushed
the
es/05-08-gitserverimplementcommitlogusingcommits
branch
from
c578d4c
to
64cf62c
Compare
eseliger
force-pushed
the
es/05-08-gitservermovecommitsuniquetobranchtocallsite
branch
from
7d955ac
to
99767c0
Compare
eseliger
force-pushed
the
es/05-08-gitserverimplementcommitlogusingcommits
branch
from
64cf62c
to
e45f971
Compare
eseliger
force-pushed
the
es/05-08-gitserverimplementcommitlogusingcommits
branch
from
e45f971
to
daa97f4
Compare
This was referenced May 10, 2024
eseliger
force-pushed
the
es/05-08-gitservermovecommitsuniquetobranchtocallsite
branch
from
99767c0
to
4c79f9f
Compare
eseliger
force-pushed
the
es/05-08-gitserverimplementcommitlogusingcommits
branch
from
daa97f4
to
b64a0f7
Compare
eseliger
force-pushed
the
es/05-08-gitservermovecommitsuniquetobranchtocallsite
branch
from
d83a205
to
e9df5e4
Compare
eseliger
force-pushed
the
es/05-08-gitserverimplementcommitlogusingcommits
branch
from
b64a0f7
to
103f5e3
Compare
eseliger
force-pushed
the
es/05-08-gitservermovecommitsuniquetobranchtocallsite
branch
from
e9df5e4
to
b130050
Compare
Base automatically changed from
es/05-08-gitservermovecommitsuniquetobranchtocallsite
to
main
May 10, 2024 23:16
This PR reimplements what CommitLog does using Commits. This reduces the surface area, but also removes an API that currently wasn't respecting sub repo permissions properly. Another side-effect of this is that we have to make more gRPC requests for indexing, but in return we accumulate less data in memory as we don't need to store all paths in all diffs here. Test plan: Existing tests still pass, adjusted test suite as well.
eseliger
force-pushed
the
es/05-08-gitserverimplementcommitlogusingcommits
branch
from
103f5e3
to
6af60b8
Compare
This was referenced May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reimplements what CommitLog does using Commits. This reduces the surface area, but also removes an API that currently wasn't respecting sub repo permissions properly.
Another side-effect of this is that we have to make more gRPC requests for indexing, but in return we accumulate less data in memory as we don't need to store all paths in all diffs here.
Closes #62103
Test plan:
Existing tests still pass, adjusted test suite as well.