Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LSIF: Remove dead LSIF jobs code #6880

Merged
merged 2 commits into from
Dec 13, 2019
Merged

LSIF: Remove dead LSIF jobs code #6880

merged 2 commits into from
Dec 13, 2019

Conversation

efritz
Copy link
Contributor

@efritz efritz commented Nov 27, 2019 •
edited
Loading

Remove old jobs code.

@efritz efritz changed the base branch from lsif-dequeue-from-postgres to lsif-postgres-upload-cleanup November 27, 2019 16:46
@efritz efritz added the lsif label Dec 2, 2019
@efritz efritz changed the title Remove dead code. LSIF: Remove dead code. Dec 3, 2019
@efritz efritz marked this pull request as ready for review December 10, 2019 16:56
@efritz efritz requested a review from a team as a code owner December 10, 2019 16:56
@chrismwendt
Copy link
Contributor

Does the UI need to get updated, too?

http://localhost:3080/github.com/chrismwendt/lsif-java/-/settings/code-intelligence

image

@efritz
Copy link
Contributor Author

efritz commented Dec 11, 2019

Does the UI need to get updated, too?

http://localhost:3080/github.com/chrismwendt/lsif-java/-/settings/code-intelligence

image

Yes, see #7157.

@efritz efritz changed the title LSIF: Remove dead code. LSIF: Remove dead LSIF jobs code Dec 11, 2019
@efritz efritz force-pushed the lsif-postgres-upload-cleanup branch from 208cf74 to dc8e931 Compare December 11, 2019 18:51
@efritz efritz changed the base branch from lsif-postgres-upload-cleanup to lsif-upload-table December 12, 2019 17:19
chrismwendt
chrismwendt approved these changes Dec 13, 2019
View reviewed changes
Copy link
Contributor

@chrismwendt chrismwendt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, I'd recommend doing a sanity check running locally before merging

slimsag
slimsag reviewed Dec 13, 2019
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@efritz efritz changed the base branch from lsif-upload-table to master December 13, 2019 04:42
@efritz efritz merged commit 7bc9ccb into master Dec 13, 2019
@efritz efritz deleted the lsif-cleanup-dead-code branch December 13, 2019 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slimsag slimsag slimsag left review comments

@chrismwendt chrismwendt chrismwendt approved these changes

@nicksnyder nicksnyder Awaiting requested review from nicksnyder

Assignees
No one assigned
Labels
lsif
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@efritz @chrismwendt @slimsag