Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add_sequence method for MinHash #186

Open
phiweger opened this issue Apr 20, 2017 · 1 comment
Open

add_sequence method for MinHash #186

phiweger opened this issue Apr 20, 2017 · 1 comment

Comments

@phiweger
Copy link

phiweger commented Apr 20, 2017

I think the API would benefit if instead of

mh = MinHash()
mh.add_sequence()
mh.add_protein()

one could type

mh.add_sequence(..., molecule='dna/protein/rna/...')

I encounter this inconvenience when directing user input from a CLI.

@ctb
Copy link
Contributor

ctb commented May 14, 2017

hmm, ok. on a look through the source code this doesn't seem to be problematic, although I worry a bit about the default behavior of sourmash compute in ignoring non-ACGTN characters for DNA - what happens if we try to add a protein FASTA file to a DNA minhash?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants