Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save full signature file in the SBT leaves? #198

Open
luizirber opened this issue Apr 28, 2017 · 2 comments
Open

Save full signature file in the SBT leaves? #198

luizirber opened this issue Apr 28, 2017 · 2 comments
Labels
sbt

Comments

@luizirber
Copy link
Member

Right now, the SBT save command will only save the signature for the specific k it was built with. We might want to save all the signatures in the original file (multiple k, potentially), to be able to share leaves between trees.

Thinking this because I created trees for refseq-k{21,31,51}, and they could all share the same leaves if it was maintained as the original input file.

It is probably a good idea to expose this to sbt_index, there might be cases were it is better to just save the specific k.
@luizirber luizirber added the sbt label Apr 28, 2017
@ctb ctb mentioned this issue May 19, 2017
Closed
@ctb
Copy link
Contributor

ctb commented May 20, 2017 via email

@luizirber luizirber mentioned this issue Oct 19, 2017
Closed
@luizirber
Copy link
Member Author

On the minified side, see #161

@luizirber luizirber mentioned this issue Nov 3, 2017
Closed
5 tasks
luizirber added a commit that referenced this issue Aug 15, 2018
@luizirber
55. Now it's failing because SBT index is saving all signatures
a8809f5 
(instead of only the one it was used to build the tree).
This was actually a feature (see #198) but it broke the SBT code
(it wasn't ready for that!)
luizirber added a commit that referenced this issue Aug 16, 2018
@luizirber
Moving loading and save sigs to rust
e7ed1ad 
move json parsing and init to rust
working on loading sigs

55 failing. Now it's failing because SBT index is saving all signatures
(instead of only the one it was used to build the tree).
This was actually a feature (see #198) but it broke the SBT code
(it wasn't ready for that!)
luizirber added a commit that referenced this issue Aug 16, 2018
@luizirber
Moving loading and save sigs to rust
599a409 
move json parsing and init to rust
working on loading sigs

55 failing. Now it's failing because SBT index is saving all signatures
(instead of only the one it was used to build the tree).
This was actually a feature (see #198) but it broke the SBT code
(it wasn't ready for that!)
luizirber added a commit that referenced this issue Oct 2, 2018
@luizirber
Moving loading and save sigs to rust
2f4981c 
move json parsing and init to rust
working on loading sigs

55 failing. Now it's failing because SBT index is saving all signatures
(instead of only the one it was used to build the tree).
This was actually a feature (see #198) but it broke the SBT code
(it wasn't ready for that!)
luizirber added a commit that referenced this issue Oct 2, 2018
@luizirber
Moving loading and save sigs to rust
5c28b28 
move json parsing and init to rust
working on loading sigs

55 failing. Now it's failing because SBT index is saving all signatures
(instead of only the one it was used to build the tree).
This was actually a feature (see #198) but it broke the SBT code
(it wasn't ready for that!)
luizirber added a commit that referenced this issue Oct 2, 2018
@luizirber
Moving loading and save sigs to rust
cca023e 
move json parsing and init to rust
working on loading sigs

55 failing. Now it's failing because SBT index is saving all signatures
(instead of only the one it was used to build the tree).
This was actually a feature (see #198) but it broke the SBT code
(it wasn't ready for that!)
luizirber added a commit that referenced this issue Oct 2, 2018
@luizirber
Moving loading and save sigs to rust
4ddf31c 
move json parsing and init to rust
working on loading sigs

55 failing. Now it's failing because SBT index is saving all signatures
(instead of only the one it was used to build the tree).
This was actually a feature (see #198) but it broke the SBT code
(it wasn't ready for that!)
luizirber added a commit that referenced this issue Oct 5, 2018
@luizirber
Moving loading and save sigs to rust
d0f9aa0 
move json parsing and init to rust
working on loading sigs

55 failing. Now it's failing because SBT index is saving all signatures
(instead of only the one it was used to build the tree).
This was actually a feature (see #198) but it broke the SBT code
(it wasn't ready for that!)
luizirber added a commit that referenced this issue Oct 5, 2018
@luizirber
Moving loading and save sigs to rust
052f595 
move json parsing and init to rust
working on loading sigs

55 failing. Now it's failing because SBT index is saving all signatures
(instead of only the one it was used to build the tree).
This was actually a feature (see #198) but it broke the SBT code
(it wasn't ready for that!)
luizirber added a commit that referenced this issue Dec 7, 2018
@luizirber
Moving loading and save sigs to rust
1a917c6 
move json parsing and init to rust
working on loading sigs

55 failing. Now it's failing because SBT index is saving all signatures
(instead of only the one it was used to build the tree).
This was actually a feature (see #198) but it broke the SBT code
(it wasn't ready for that!)
luizirber added a commit that referenced this issue Dec 7, 2018
@luizirber
Moving loading and save sigs to rust
d5cbf83 
move json parsing and init to rust
working on loading sigs

55 failing. Now it's failing because SBT index is saving all signatures
(instead of only the one it was used to build the tree).
This was actually a feature (see #198) but it broke the SBT code
(it wasn't ready for that!)
luizirber added a commit that referenced this issue Dec 7, 2018
@luizirber
Moving loading and save sigs to rust
fb4e996 
move json parsing and init to rust
working on loading sigs

55 failing. Now it's failing because SBT index is saving all signatures
(instead of only the one it was used to build the tree).
This was actually a feature (see #198) but it broke the SBT code
(it wasn't ready for that!)
luizirber added a commit that referenced this issue Dec 7, 2018
@luizirber
Moving loading and save sigs to rust
b1112c5 
move json parsing and init to rust
working on loading sigs

55 failing. Now it's failing because SBT index is saving all signatures
(instead of only the one it was used to build the tree).
This was actually a feature (see #198) but it broke the SBT code
(it wasn't ready for that!)
luizirber added a commit that referenced this issue Dec 7, 2018
@luizirber
Moving loading and save sigs to rust
99ba8ef 
move json parsing and init to rust
working on loading sigs

55 failing. Now it's failing because SBT index is saving all signatures
(instead of only the one it was used to build the tree).
This was actually a feature (see #198) but it broke the SBT code
(it wasn't ready for that!)
luizirber added a commit that referenced this issue Dec 10, 2018
@luizirber
Moving loading and save sigs to rust
e805f1e 
move json parsing and init to rust
working on loading sigs

55 failing. Now it's failing because SBT index is saving all signatures
(instead of only the one it was used to build the tree).
This was actually a feature (see #198) but it broke the SBT code
(it wasn't ready for that!)
luizirber added a commit that referenced this issue Dec 24, 2018
@luizirber
Moving loading and save sigs to rust
233c900 
move json parsing and init to rust
working on loading sigs

55 failing. Now it's failing because SBT index is saving all signatures
(instead of only the one it was used to build the tree).
This was actually a feature (see #198) but it broke the SBT code
(it wasn't ready for that!)
luizirber added a commit that referenced this issue Dec 24, 2018
@luizirber
Moving loading and save sigs to rust
1573d7c 
move json parsing and init to rust
working on loading sigs

55 failing. Now it's failing because SBT index is saving all signatures
(instead of only the one it was used to build the tree).
This was actually a feature (see #198) but it broke the SBT code
(it wasn't ready for that!)
luizirber added a commit that referenced this issue Dec 28, 2018
@luizirber
Moving loading and save sigs to rust
5e8e376 
move json parsing and init to rust
working on loading sigs

55 failing. Now it's failing because SBT index is saving all signatures
(instead of only the one it was used to build the tree).
This was actually a feature (see #198) but it broke the SBT code
(it wasn't ready for that!)
luizirber added a commit that referenced this issue Jan 9, 2019
@luizirber
Moving loading and save sigs to rust
d63d1fc 
move json parsing and init to rust
working on loading sigs

55 failing. Now it's failing because SBT index is saving all signatures
(instead of only the one it was used to build the tree).
This was actually a feature (see #198) but it broke the SBT code
(it wasn't ready for that!)
luizirber added a commit that referenced this issue Jan 10, 2019
@luizirber
Moving loading and save sigs to rust
2ba9206 
move json parsing and init to rust
working on loading sigs

55 failing. Now it's failing because SBT index is saving all signatures
(instead of only the one it was used to build the tree).
This was actually a feature (see #198) but it broke the SBT code
(it wasn't ready for that!)
luizirber added a commit that referenced this issue Mar 21, 2019
@luizirber
Moving loading and save sigs to rust
bd0fcc9 
move json parsing and init to rust
working on loading sigs

55 failing. Now it's failing because SBT index is saving all signatures
(instead of only the one it was used to build the tree).
This was actually a feature (see #198) but it broke the SBT code
(it wasn't ready for that!)
luizirber added a commit that referenced this issue Apr 18, 2019
@luizirber
Moving loading and save sigs to rust
97b9356 
move json parsing and init to rust
working on loading sigs

55 failing. Now it's failing because SBT index is saving all signatures
(instead of only the one it was used to build the tree).
This was actually a feature (see #198) but it broke the SBT code
(it wasn't ready for that!)
luizirber added a commit that referenced this issue Apr 21, 2019
@luizirber
Moving loading and save sigs to rust
1f58b32 
move json parsing and init to rust
working on loading sigs

55 failing. Now it's failing because SBT index is saving all signatures
(instead of only the one it was used to build the tree).
This was actually a feature (see #198) but it broke the SBT code
(it wasn't ready for that!)
luizirber added a commit that referenced this issue Apr 22, 2019
@luizirber
Moving loading and save sigs to rust
252624a 
move json parsing and init to rust
working on loading sigs

55 failing. Now it's failing because SBT index is saving all signatures
(instead of only the one it was used to build the tree).
This was actually a feature (see #198) but it broke the SBT code
(it wasn't ready for that!)
luizirber added a commit that referenced this issue Jul 7, 2019
@luizirber
Moving loading and save sigs to rust
2b34f85 
move json parsing and init to rust
working on loading sigs

55 failing. Now it's failing because SBT index is saving all signatures
(instead of only the one it was used to build the tree).
This was actually a feature (see #198) but it broke the SBT code
(it wasn't ready for that!)
luizirber added a commit that referenced this issue Aug 24, 2019
@luizirber
Moving loading and save sigs to rust
f999324 
move json parsing and init to rust
working on loading sigs

55 failing. Now it's failing because SBT index is saving all signatures
(instead of only the one it was used to build the tree).
This was actually a feature (see #198) but it broke the SBT code
(it wasn't ready for that!)
@ctb ctb mentioned this issue Jul 2, 2020
Closed
This was referenced Apr 10, 2021
Open
Closed
@ctb ctb mentioned this issue May 15, 2021
Open
2 tasks
@ctb ctb mentioned this issue Jun 13, 2021
Closed
@ctb ctb mentioned this issue Jun 29, 2021
Open
@ctb ctb mentioned this issue Mar 26, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
sbt
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@luizirber @ctb