[MRG] Add sourmash logo to docs and README #1127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1127 +/- ##
==========================================
+ Coverage 83.79% 93.04% +9.25%
==========================================
Files 98 74 -24
Lines 9063 5810 -3253
==========================================
- Hits 7594 5406 -2188
+ Misses 1469 404 -1065
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
luizirber
commented
Jul 25, 2020
|
Before: |
|
👍 |
luizirber
changed the title
|
Ready for review and merge @ctb @taylorreiter |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #673
I also removed the customized template for the docs, opting for using the one that comes by default with Alabaster. It is a bit different (for example, "Navigation" instead of "Table of Contents" in the sidebar), but this way we don't need to keep updating our copy when the one from the theme is updated.
TODO:
Checklist
make testDid it pass the tests?make coverageIs the new code covered?without a major version increment. Changing file formats also requires a
major version number increment.
changes were made?