[MRG] Remove deprecated compare from minhash tests
#1129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1129 +/- ##
==========================================
+ Coverage 83.89% 93.02% +9.12%
==========================================
Files 98 74 -24
Lines 9124 5810 -3314
==========================================
- Hits 7655 5405 -2250
+ Misses 1469 405 -1064
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
ctb
changed the title
compare from minhash testscompare from minhash tests
|
Ready for review @luizirber |
luizirber
approved these changes
Jul 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1101, removing lots of deprecation warnings :)
Ref #882 #889 for original code changes that led to deprecation, specifically this line.
In #889 we deprecated
comparein favor ofjaccardin the MinHash Python API becausejaccardis by definition a similarity metric that does not take into account abundance.compareandsimilaritywere confusingly alike in their name.This PR replaces
comparewith eithersimilarity(for calculations with abundance) orjaccard(for calculations without abundance).The only tricky bit here for migration is that the user will need to choose
similarityorjaccardin the future.make testDid it pass the tests?make coverageIs the new code covered?without a major version increment. Changing file formats also requires a
major version number increment.
changes were made?