Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] deprecate import sourmash_lib #1143

Merged
merged 1 commit into from
Aug 3, 2020
Merged

Conversation

ctb
Copy link
Contributor

@ctb ctb commented Aug 3, 2020

Fixes #441.

As in #1128 (comment), I used FutureWarning instead of DeprecationWarning so it would show up without any special configuration.

  • Is it mergeable?
  • make test Did it pass the tests?
  • make coverage Is the new code covered?
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Was a spellchecker run on the source code and documentation after
    changes were made?

@ctb ctb changed the title deprecate import sourmash_lib [MRG] deprecate import sourmash_lib Aug 3, 2020
@ctb ctb requested a review from luizirber August 3, 2020 12:51
@codecov
Copy link

codecov bot commented Aug 3, 2020

Codecov Report

Merging #1143 into master will increase coverage by 9.14%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1143      +/-   ##
==========================================
+ Coverage   83.88%   93.03%   +9.14%     
==========================================
  Files          98       74      -24     
  Lines        9124     5812    -3312     
==========================================
- Hits         7654     5407    -2247     
+ Misses       1470      405    -1065     
Flag Coverage Δ
#rusttests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sourmash_lib/__init__.py 100.00% <100.00%> (ø)
src/core/src/signature.rs
src/core/src/index/mod.rs
src/core/src/sketch/minhash.rs
src/core/src/cmd.rs
src/core/src/index/search.rs
src/core/src/ffi/utils.rs
src/core/src/errors.rs
src/core/tests/test.rs
src/core/src/lib.rs
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16e6934...80dfa71. Read the comment docs.

@luizirber luizirber merged commit 19b32b7 into master Aug 3, 2020
@luizirber luizirber deleted the deprecate_sourmash_lib branch August 3, 2020 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate 'import sourmash_lib' at some point
2 participants