Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] add cibuildwheel to GitHub actions #1244

Merged
merged 24 commits into from
Dec 7, 2020
Merged

Conversation

ctb
Copy link
Contributor

@ctb ctb commented Nov 26, 2020

Since TravisCI is no longer working well for building wheels, let's give GitHub Actions a try!

  • Is it mergeable?
  • make test Did it pass the tests?
  • make coverage Is the new code covered?
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Was a spellchecker run on the source code and documentation after
    changes were made?

@codecov
Copy link

codecov bot commented Nov 26, 2020

Codecov Report

Merging #1244 (61d0e07) into latest (95bd546) will decrease coverage by 54.26%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           latest    #1244       +/-   ##
===========================================
- Coverage   83.31%   29.05%   -54.27%     
===========================================
  Files         103       76       -27     
  Lines        9601     5910     -3691     
===========================================
- Hits         7999     1717     -6282     
- Misses       1602     4193     +2591     
Flag Coverage Δ
rusttests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sourmash/cli/plot.py 11.76% <0.00%> (-88.24%) ⬇️
sourmash/lca/lca_db.py 10.31% <0.00%> (-86.62%) ⬇️
sourmash/sig/__main__.py 6.71% <0.00%> (-86.58%) ⬇️
sourmash/cli/lca/index.py 13.63% <0.00%> (-86.37%) ⬇️
sourmash/lca/command_index.py 8.02% <0.00%> (-86.10%) ⬇️
sourmash/cli/gather.py 14.28% <0.00%> (-85.72%) ⬇️
sourmash/cli/lca/classify.py 14.28% <0.00%> (-85.72%) ⬇️
sourmash/cli/lca/summarize.py 14.28% <0.00%> (-85.72%) ⬇️
sourmash/cli/lca/compare_csv.py 14.28% <0.00%> (-85.72%) ⬇️
sourmash/cli/search.py 15.00% <0.00%> (-85.00%) ⬇️
... and 89 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95bd546...61d0e07. Read the comment docs.

@luizirber
Copy link
Member

I'm taking over this PR and also bringing the remaining checks from Travis (no point in blocking PR merging because Travis is not running our builds)

@ctb
Copy link
Contributor Author

ctb commented Dec 7, 2020 via email

@luizirber luizirber force-pushed the github_actions_wheel branch 2 times, most recently from 4db4a51 to c509820 Compare December 7, 2020 21:49
@luizirber luizirber changed the title [WIP] add cibuildwheel to GitHub actions [MRG] add cibuildwheel to GitHub actions Dec 7, 2020
@luizirber
Copy link
Member

I disabled most tests from Travis, but didn't replace them yet with the GH actions version. I'll open a new PR for that, and leave this one only for fixing wheels

(travis tests are not being executed anyway, since we are over our quota =/)

@luizirber
Copy link
Member

And codecov is failing because the Python tests are not being reported 😬

Ready for review and merge @ctb

@ctb
Copy link
Contributor Author

ctb commented Dec 7, 2020

I approve of it, but since I'm the original author I can't officially approve it for merge :). So... let's just merge when tests pass.

@luizirber luizirber closed this Dec 7, 2020
@luizirber luizirber merged commit b99ed8e into latest Dec 7, 2020
@luizirber luizirber deleted the github_actions_wheel branch December 7, 2020 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants