[WIP] Ertl estimators for scaled minhash #1270
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## latest #1270 +/- ##
==========================================
+ Coverage 89.88% 94.93% +5.05%
==========================================
Files 124 97 -27
Lines 19889 16266 -3623
Branches 1515 1515
==========================================
- Hits 17877 15442 -2435
+ Misses 1783 595 -1188
Partials 229 229
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
luizirber
force-pushed
the
minhash_ertl
branch
from
70bc32f
to
b730361
Compare
luizirber
force-pushed
the
minhash_ertl
branch
7 times, most recently
from
e305b82
to
4c7e2e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea of this PR is to estimate the cardinality of the original dataset using the scaled minhash as a proxy
(the scaled minhash has a reduced resolution HLL equivalent to full resolution HLL from the original dataset), keeping it backwards-compatible with existing sigs (since we can build the reduced HLL from the scaled minhash).
(Surfacing this after talking with @bluegenes)
TODO
Checklist
make testDid it pass the tests?make coverageIs the new code covered?without a major version increment. Changing file formats also requires a
major version number increment.
changes were made?