Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move wheel building from Travis to GitHub Actions #1295

Merged
merged 5 commits into from
Feb 2, 2021
Merged

Conversation

luizirber
Copy link
Member

@luizirber luizirber commented Feb 1, 2021

This PR completely removes Travis from our CI setup.

This also sort of setup the way for universal2/arm64 wheels on macOS (once it is more stable).

Checklist

  • Is it mergeable?
  • make test Did it pass the tests?
  • make coverage Is the new code covered?
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Was a spellchecker run on the source code and documentation after
    changes were made?

@codecov
Copy link

codecov bot commented Feb 1, 2021

Codecov Report

Merging #1295 (f6515bc) into latest (fe5d210) will increase coverage by 5.26%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           latest    #1295      +/-   ##
==========================================
+ Coverage   88.69%   93.96%   +5.26%     
==========================================
  Files         125       98      -27     
  Lines       18281    14665    -3616     
  Branches     1440     1440              
==========================================
- Hits        16215    13780    -2435     
+ Misses       1819      638    -1181     
  Partials      247      247              
Flag Coverage Δ
python 93.96% <ø> (ø)
rust ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/core/src/errors.rs
src/core/src/lib.rs
src/core/src/cmd.rs
src/core/src/signature.rs
src/core/src/ffi/hyperloglog.rs
src/core/src/ffi/signature.rs
src/core/src/index/bigsi.rs
src/core/src/encodings.rs
src/core/src/ffi/nodegraph.rs
src/core/src/sketch/nodegraph.rs
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe5d210...f6515bc. Read the comment docs.

@ctb ctb changed the title [WIP] Move wheel buiding from Travis to GitHub Actions [WIP] Move wheel building from Travis to GitHub Actions Feb 2, 2021
@luizirber luizirber changed the title [WIP] Move wheel building from Travis to GitHub Actions Move wheel building from Travis to GitHub Actions Feb 2, 2021
@luizirber luizirber requested a review from ctb February 2, 2021 19:52
@luizirber
Copy link
Member Author

Ready for review and merge @ctb

@ctb ctb merged commit 43ae278 into latest Feb 2, 2021
@ctb ctb deleted the remove_travis branch February 2, 2021 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants