-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRG] add proper newline output for csv module #1319
Conversation
Codecov Report
@@ Coverage Diff @@
## latest #1319 +/- ##
==========================================
+ Coverage 89.15% 94.41% +5.25%
==========================================
Files 123 96 -27
Lines 18593 14982 -3611
Branches 1432 1433 +1
==========================================
- Hits 16577 14145 -2432
+ Misses 1780 601 -1179
Partials 236 236
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Ready for review @bluegenes @luizirber! |
lgtm, but i don't have a windows machine to test on :) |
lol, indeed! barring input from @luizirber I think we'll just have to merge & release it and tag in the creator of the original issue. |
Opens CSV files with
newline=''
as specified in Python docs (link).Fixes #1318.
Unfortunately there seems to be no reliable way to test this PR on non-Windows machines because the output is identical with or without
newline=''
!Checklist
make test
Did it pass the tests?make coverage
Is the new code covered?without a major version increment. Changing file formats also requires a
major version number increment.
changes were made?