Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] Update and fix cbindgen config and CI #1473

Merged
merged 1 commit into from
Apr 19, 2021
Merged

Conversation

luizirber
Copy link
Member

This PR add some config options for cbindgen to account for some changes to the default C header format it generates.

Also updates cbindgen from 0.14 to 0.19 in CI.

@luizirber luizirber changed the title [WIP] Update and fix cbindgen config and CI [MRG] Update and fix cbindgen config and CI Apr 19, 2021
@luizirber luizirber added the rust label Apr 19, 2021
@luizirber
Copy link
Member Author

Ready for merge @ctb @erikyoung85

@codecov
Copy link

codecov bot commented Apr 19, 2021

Codecov Report

Merging #1473 (7fccbf7) into latest (d45baba) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           latest    #1473   +/-   ##
=======================================
  Coverage   89.58%   89.58%           
=======================================
  Files         122      122           
  Lines       18989    18989           
  Branches     1455     1455           
=======================================
  Hits        17011    17011           
  Misses       1750     1750           
  Partials      228      228           
Flag Coverage Δ
python 94.80% <ø> (+5.21%) ⬆️
rust 67.37% <ø> (-27.26%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/core/src/index/mod.rs 61.53% <0.00%> (ø)
src/core/src/index/linear.rs 17.30% <0.00%> (ø)
src/core/src/ffi/hyperloglog.rs 0.00% <0.00%> (ø)
src/core/tests/test.rs 100.00% <0.00%> (ø)
src/core/src/ffi/utils.rs 0.00% <0.00%> (ø)
src/core/src/ffi/nodegraph.rs 0.00% <0.00%> (ø)
src/core/src/encodings.rs 77.77% <0.00%> (ø)
src/core/src/index/bigsi.rs 89.47% <0.00%> (ø)
src/core/src/signature.rs 59.39% <0.00%> (ø)
src/core/src/index/search.rs 100.00% <0.00%> (ø)
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d45baba...7fccbf7. Read the comment docs.

@ctb
Copy link
Contributor

ctb commented Apr 19, 2021

Let's wait 'til tests pass before merging.

@luizirber luizirber merged commit eb2b210 into latest Apr 19, 2021
@luizirber luizirber deleted the cbindgen_config branch April 19, 2021 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants