[MRG] added --name to merge

[hehouts]

sourmash sig merge now supports optional --name to set the name of the merged signature.

fixes #1213

[codecov]

Codecov Report

Merging #1480 (fcdfce2) into latest (8fbf83f) will increase coverage by 5.13%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           latest    #1480      +/-   ##
==========================================
+ Coverage   89.76%   94.90%   +5.13%     
==========================================
  Files         123       96      -27     
  Lines       19553    15942    -3611     
  Branches     1497     1497              
==========================================
- Hits        17552    15129    -2423     
+ Misses       1775      587    -1188     
  Partials      226      226              

Flag	Coverage Δ
python	94.90% <100.00%> (+<0.01%)	⬆️
rust	?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
src/sourmash/cli/sig/merge.py	100.00% <100.00%> (ø)
src/sourmash/sig/__main__.py	90.79% <100.00%> (ø)
tests/test_cmd_signature.py	100.00% <100.00%> (ø)
src/core/src/signature.rs
src/core/tests/test.rs
src/core/src/index/sbt/mod.rs
src/core/src/ffi/signature.rs
src/core/src/sketch/hyperloglog/mod.rs
src/core/src/ffi/mod.rs
src/core/src/sketch/nodegraph.rs
... and 20 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8fbf83f...fcdfce2. Read the comment docs.

[ctb]

hi @hehouts please be sure to add your ORCID here - thanks!

[hehouts]

hey @ctb .
My OrcID is 0000-0002-7954-4793, is there a way to link it to the pull request or something?

[ctb]

On Fri, Apr 23, 2021 at 05:48:32PM -0700, Hannah Eve Houts wrote: > hey @ctb . My OrcID is 0000-0002-7954-4793, is there a way to link it to the pull request or something?

you just did! (no, there's no official way to link it :)

[hehouts]

@ctb @bluegenes: please review

[ctb]

LGTM! Do you have the "merge and squash" button available to you, @hehouts? If so, please do the honors :)

[ctb]

for future reference, we typically use non-CamelCase variables for things that aren't class names. So it's MinHash and SourmashSignature but load_signature. In this case, I would suggest assigned_sig_name. As this is a test, however, there's no need to change it, this is just an FYI!