Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] Partial fix for doc build issues with notebooks #1516

Merged
merged 1 commit into from
May 12, 2021

Conversation

luizirber
Copy link
Member

Seems like something changed with myst-parser 0.14.0 that broke our notebooks. At first it seemed to be missing tags in the metadata field of each cell in the notebook, but when I fixed that it triggered errors about missing widgets fields, and so... I'm pinning myst-parser to 0.13.7 for now.

@codecov
Copy link

codecov bot commented May 12, 2021

Codecov Report

Merging #1516 (5b1b246) into latest (f60c44d) will increase coverage by 5.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           latest    #1516      +/-   ##
==========================================
+ Coverage   90.26%   95.29%   +5.03%     
==========================================
  Files         126       99      -27     
  Lines       21099    17399    -3700     
  Branches     1585     1585              
==========================================
- Hits        19045    16581    -2464     
+ Misses       1827      591    -1236     
  Partials      227      227              
Flag Coverage Δ
python 95.29% <ø> (ø)
rust ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/core/src/signature.rs
src/core/src/index/linear.rs
src/core/src/sketch/hyperloglog/mod.rs
src/core/src/index/bigsi.rs
src/core/src/sketch/hyperloglog/estimators.rs
src/core/src/ffi/signature.rs
src/core/tests/minhash.rs
src/core/src/index/storage.rs
src/core/src/wasm.rs
src/core/src/sketch/minhash.rs
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f60c44d...5b1b246. Read the comment docs.

@luizirber
Copy link
Member Author

Ready for review and merge @ctb @bluegenes

Copy link
Contributor

@bluegenes bluegenes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@luizirber luizirber merged commit 6922f38 into latest May 12, 2021
@luizirber luizirber deleted the doc_notebooks_upgrade branch May 12, 2021 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants