Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] add signature names to known/unknown hash sigs output by sourmash prefetch #1646

Merged
merged 3 commits into from
Jun 29, 2021

Conversation

ctb
Copy link
Contributor

@ctb ctb commented Jun 28, 2021

When running genome-grist with the new picklist code over in dib-lab/genome-grist#94, I noticed that sourmash prefetch --save-matching-hashes and --save-unmatched-hashes created signatures with empty names, which then led to the downstream gather output for those signatures having no names, either. This fixes that to set the names to {query.name}-known and {query.name}-unknown respectively.

@codecov
Copy link

codecov bot commented Jun 28, 2021

Codecov Report

Merging #1646 (a6801d5) into latest (e386085) will increase coverage by 7.40%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           latest    #1646      +/-   ##
==========================================
+ Coverage   81.92%   89.32%   +7.40%     
==========================================
  Files         112       85      -27     
  Lines       11441     7741    -3700     
  Branches     1430     1432       +2     
==========================================
- Hits         9373     6915    -2458     
+ Misses       1813      569    -1244     
- Partials      255      257       +2     
Flag Coverage Δ
python 89.32% <75.00%> (-0.02%) ⬇️
rust ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/sourmash/commands.py 86.23% <75.00%> (-0.15%) ⬇️
src/core/src/sketch/nodegraph.rs
src/core/src/index/linear.rs
src/core/src/wasm.rs
src/core/src/ffi/nodegraph.rs
src/core/src/sketch/hyperloglog/mod.rs
src/core/tests/minhash.rs
src/core/src/index/storage.rs
src/core/src/ffi/hyperloglog.rs
src/core/src/index/sbt/mod.rs
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e386085...a6801d5. Read the comment docs.

@ctb
Copy link
Contributor Author

ctb commented Jun 28, 2021

anticipating that the remaining tests are going to pass... ready for review and merge, thx! @sourmash-bio/devs

src/sourmash/commands.py Outdated Show resolved Hide resolved
@ctb ctb merged commit 4fce5ab into latest Jun 29, 2021
@ctb ctb deleted the add/names_to_prefetch_sigs branch June 29, 2021 14:22
@ctb
Copy link
Contributor Author

ctb commented Jun 29, 2021

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants