Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] add optional abundance preservation to sourmash signature intersect #747

Merged
merged 2 commits into from Oct 22, 2019

Conversation

ctb
Copy link
Contributor

@ctb ctb commented Oct 19, 2019

This PR adds an option --abundances-from/-A to sourmash signature intersect that allows the user to specify a specific signature from which to preserve abundances in the output signature.

Ref #743.

  • Is it mergeable?
  • make test Did it pass the tests?
  • make coverage Is the new code covered?
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Was a spellchecker run on the source code and documentation after
    changes were made?

@codecov
Copy link

codecov bot commented Oct 19, 2019

Codecov Report

Merging #747 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #747      +/-   ##
==========================================
+ Coverage   88.59%   88.62%   +0.03%     
==========================================
  Files          30       30              
  Lines        4727     4740      +13     
  Branches       46       46              
==========================================
+ Hits         4188     4201      +13     
  Misses        536      536              
  Partials        3        3
Impacted Files Coverage Δ
sourmash/sig/__main__.py 95.32% <100%> (+0.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee195b4...502eee9. Read the comment docs.

@ctb
Copy link
Contributor Author

ctb commented Oct 19, 2019

Ready for review @luizirber

@taylorreiter
Copy link
Contributor

Looks good to me! So many new possibilities!

@ctb ctb merged commit 99de03c into master Oct 22, 2019
@ctb ctb deleted the update/intersect_abund branch October 22, 2019 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants