Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force signature order in test_sig_filter_1 to fix heisenbug #761

Merged
merged 3 commits into from
Oct 23, 2019

Conversation

ctb
Copy link
Contributor

@ctb ctb commented Oct 23, 2019

  • Is it mergeable?
  • make test Did it pass the tests?
  • make coverage Is the new code covered?
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Was a spellchecker run on the source code and documentation after
    changes were made?

@ctb ctb changed the title Force signature order in test_sig_filter_1 to fix heisenbug [WIP] Force signature order in test_sig_filter_1 to fix heisenbug Oct 23, 2019
@codecov
Copy link

codecov bot commented Oct 23, 2019

Codecov Report

Merging #761 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #761   +/-   ##
=======================================
  Coverage   88.42%   88.42%           
=======================================
  Files          30       30           
  Lines        4786     4786           
  Branches       46       46           
=======================================
  Hits         4232     4232           
  Misses        551      551           
  Partials        3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 134748b...67a9356. Read the comment docs.

@luizirber luizirber changed the title [WIP] Force signature order in test_sig_filter_1 to fix heisenbug Force signature order in test_sig_filter_1 to fix heisenbug Oct 23, 2019
@luizirber luizirber merged commit 94ae59c into master Oct 23, 2019
@luizirber luizirber deleted the fix/test_sig_filter_1 branch October 23, 2019 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants