New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRG] improve error handling etc. in sourmash lca index
.
#798
Conversation
Codecov Report
@@ Coverage Diff @@
## master #798 +/- ##
==========================================
+ Coverage 79.62% 79.74% +0.11%
==========================================
Files 45 45
Lines 6592 6630 +38
Branches 454 454
==========================================
+ Hits 5249 5287 +38
Misses 1042 1042
Partials 301 301
Continue to review full report at Codecov.
|
@luizirber some more tests are needed, but I'd appreciate your quick checkover of the cached_property stuff in |
…/require_taxonomy
…to lca/require_taxonomy
sourmash lca index
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the @cached_property
comments, LGTM
But tests are failing in |
Co-Authored-By: Luiz Irber <luizirber@users.noreply.github.com>
Co-Authored-By: Luiz Irber <luizirber@users.noreply.github.com>
Co-Authored-By: Luiz Irber <luizirber@users.noreply.github.com>
Co-Authored-By: Luiz Irber <luizirber@users.noreply.github.com>
thanks for all the suggestions - will merge when tests pass! |
Many LCA fixes/cleanups in reaction to challenges and opportunities from working with the GTDB taxonomy.
LCA updates:
--require-taxonomy
and checks for duplicate identifiers tosourmash lca index
.--force
argument passing appropriately in response to newly failing tests.Non LCA fixes:
make build
to always execute with a.PHONY
magic dependencyio.StringIO
toio.BytesIO
make test
Did it pass the tests?make coverage
Is the new code covered?without a major version increment. Changing file formats also requires a
major version number increment.
changes were made?