-
-
Notifications
You must be signed in to change notification settings - Fork 793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not restart docker at each deployment #21
Comments
👍 it hasn't necessarily bitten me yet, but this doesn't feel right to me. I'd expect restarts only when notified as @Soulou recommends or perhaps adding an attribute checking |
Definitely see how this is an issue. Will refactor that code now. |
Released 0.9.1 (commit: 91cae5b) that should resolve this issue. Should've noticed this in the original pull request. Sorry about that. |
Thank you @bflad |
Thanks, @bflad ! |
At each
chef-client
orknife solo cook
, docker is stopped then restarted event if nothing has changed, no update, no configuration change.Maybe it would be more interesting to user
notifies :restart, "service[docker]"
? To restart it only when needed. (First deployment, Update and Confinguration change)The text was updated successfully, but these errors were encountered: