Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not restart docker at each deployment #21

Closed
Soulou opened this issue Oct 7, 2013 · 5 comments
Closed

Do not restart docker at each deployment #21

Soulou opened this issue Oct 7, 2013 · 5 comments

Comments

@Soulou
Copy link
Contributor

Soulou commented Oct 7, 2013

At each chef-client or knife solo cook, docker is stopped then restarted event if nothing has changed, no update, no configuration change.

Maybe it would be more interesting to user notifies :restart, "service[docker]" ? To restart it only when needed. (First deployment, Update and Confinguration change)

@meatballhat
Copy link

👍 it hasn't necessarily bitten me yet, but this doesn't feel right to me. I'd expect restarts only when notified as @Soulou recommends or perhaps adding an attribute checking only_if or not_if to service[docker stop].

@bflad
Copy link
Contributor

bflad commented Oct 7, 2013

Definitely see how this is an issue. Will refactor that code now.

@bflad
Copy link
Contributor

bflad commented Oct 8, 2013

Released 0.9.1 (commit: 91cae5b) that should resolve this issue. Should've noticed this in the original pull request. Sorry about that.

@bflad bflad closed this as completed Oct 8, 2013
@Soulou
Copy link
Contributor Author

Soulou commented Oct 8, 2013

Thank you @bflad

@meatballhat
Copy link

Thanks, @bflad !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants