Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service Provider needs to load_current_resource #15

Closed
brianbianco opened this issue Aug 9, 2012 · 5 comments
Closed

Service Provider needs to load_current_resource #15

brianbianco opened this issue Aug 9, 2012 · 5 comments
Milestone

Comments

@brianbianco
Copy link
Contributor

The redis_service provider needs to both implement load_current_resource, and also call updated_by_last_action when some action is taken. This will allow it to send notifications and receive subscriptions.

@andreacampi
Copy link

May be obvious, but…
Once you get updated_by_last_action right, you should also make sure configuration changes cause a restart.

@brianbianco
Copy link
Contributor Author

I am not sure It should do this by default. Redis does not contain the ability to simply "reload" so any restart or redis carries with it some serious implications. Perhaps a better idea is to make an attribute that flags it as ok to restart on configuration changes.

@andreacampi
Copy link

+1 on that :)

@brianbianco
Copy link
Contributor Author

This has been resolved by the fact that I now use the chef service resource instead of a custom redisio_service resource. Done and done! Commit that fixes this is ac4553c

@lock
Copy link

lock bot commented Nov 28, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Nov 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants