Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Render to MP3 #110

Open
sowbug opened this issue Mar 13, 2023 · 1 comment
Open

Render to MP3 #110

sowbug opened this issue Mar 13, 2023 · 1 comment
Labels
enhancement New feature or request
Milestone
Halloween

Comments

@sowbug
Copy link
Owner

sowbug commented Mar 13, 2023

No description provided.

@sowbug sowbug added the enhancement New feature or request label Mar 13, 2023
@sowbug
Copy link
Owner Author

sowbug commented May 19, 2023

Why I keep bouncing off this:

  1. There is no open-source MP3 encoding crate. There are wrappers around the LGPL-licensed LAME, but I haven't had the time to research whether LGPL is compatible with my project plans.
  2. If I resolve issue 1, existing crates still feel a bit janky. https://crates.io/crates/mp3lame-encoder looks fine (and the author shares my concern about LGPL), but it looks like normal usage requires unsafe, which is probably fine, but again I need to research exactly what's going on.
  3. Lack of MP3 encoding actually hasn't been a blocker for me. I don't really care if local files are 10x the size they could be, and when I'm debugging output, I wanted the WAV anyway.

This is why I am going to defer this to a later milestone.

@sowbug sowbug modified the milestones: Icebox, Halloween Sep 13, 2023
@sowbug sowbug mentioned this issue Sep 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
Halloween
Development

No branches or pull requests
1 participant
@sowbug