JEI rendering errors [bug] [high importance]

[DanHolli]

whole original discussion with the creator of JEI about the problem

JustEnoughItems issue #372

[DanHolli]

until this is solved i won't be using optifine (witch I hate to need to do)

[sp614x]

Is this reproducible with only OptiFine and JEI installed (no other mods)?

[mezz]

Here's a crash log with fewer mods, but I haven't seen anyone try to reproduce it with a minimal setup yet.
https://gist.github.com/mightydanp/06dbd8f674ac06ccb5e9f7025c59137b

JEI copies some of the Minecraft item rendering code into its own classes with some small changes in order to render the item list with fewer OpenGL context changes. If Optifine is changing that code in Minecraft and expects it to work a certain way, it may be relevant to this bug.

Rendering code starts here:
https://github.com/mezz/JustEnoughItems/blob/1.10/src/main/java/mezz/jei/gui/ingredients/GuiItemStackFastList.java#L96-L161
and the copied stuff starts here:
https://github.com/mezz/JustEnoughItems/blob/1.10/src/main/java/mezz/jei/gui/ingredients/GuiItemStackFast.java#L74-L105

I also have a fairly small AccessTransformer here:
https://github.com/mezz/JustEnoughItems/blob/1.10/src/main/resources/jei_at.cfg

[sp614x]

The "IllegalStateException: Already building!" is a follow-up error.
Something else have crashed already and because of this the VertexBuffer is still open and the next code which tries to use the VertexBuffer gets the "Already building" error.
The previous error may be visible in the error log.

[DanHolli]

it only happens for me with optifine installed
(I dislike the VERY convinent 'Close and comment' button)

[sp614x]

@DanHolli123 Error log with only OptiFine and JEI?
Steps to reproduce?

[ghost]

When using only OptiFine_1.10.2_HD_U_C3 and jei_1.10.2-3.12.6.304 on Forge 2099 this error does not occur for me. However I've had it happen when searching for items, earlier today in fact, on a larger mod order. So I'll probably spend a bit of time going through the mods in my load order manually and finding which recipes this happens for. No guarantees on timeliness however.

[ghost]

The only mod that has thrown an error for me, when used in conjuction with the versions of Optifine and JEI listed above, so far is Inductive Automation (and its dependency library, which has a long and complicated name that I don't have with me atm). I'll try reproducing the crash on a minimal load order later and report the crash to IA's mod author meanwhile.

[ghost]

okay, so IA is definitely one mod that causes issues, but I think that by hiding its items from the JEI menu this crash can be bypassed. obviously this isn't a proper workaround, and there may be more mods that have errors with JEI and Optifine.

to clarify, JEI and Optifine work together fine; and, JEI and IA work together fine (I haven't tested only IA and Optifine). it seems to be that when the three are combined that a crash occurs. whose end is this on?

[sp614x]

In order to be fixed the bug has to be reproducible with the minimal number of mods involved.
Best would be only 2 mods (optifine and another), but sometimes there are 3-mod dependancies.

[ghost]

With only Optifine, IA and its dependency (CD4017BE_lib-1.10.2-4.2.0) loaded, I get an identical crash when attempting to navigate to IA's creative tab in creative mode. The crash does not occur when loading only Optifine & CD4017BE_lib. The crash does not occur with Optifine disabled. JEI, then, seems to be unrelated to this case. I believe the words required here are, "my bad". xP

Crash: http://pastebin.com/raw/E2cFHdBT
Log: http://puu.sh/rGV7N/0f6a9b4542.log

CD4017BE/InductiveAutomation#17

[sp614x]

Tested MC 1.10.2 + Forge #2099 + preview OptiFine C4 + IA 5.1.1 + CD4017BE_lib 4.2.0.
Not crashing when browsing items in the IA creative tab, everything seems to work.
The error log shows missing model variants, but this also happens without OptiFine.
Can you test again with the latest preview OptiFine C4?

[ghost]

Fantastic, the preview C4 works perfectly (as far as I can tell). Thanks for fixing that so quickly!

[DanHolli]

will try soon