Skip to content
This repository has been archived by the owner on Dec 31, 2020. It is now read-only.

Embedding via mapJSON results in NoScript (probably others) logging a XSS issue #10

Closed
spaasis opened this issue Oct 5, 2016 · 1 comment
Labels

Comments

@spaasis
Copy link
Owner

spaasis commented Oct 5, 2016

When embedding direct JSON files (for example https://simopaasisalo.github.io/MakeMaps_embed/tests/pori.html), an XSS protection is triggered in NoScript (https://noscript.net/).

I tried to use encodeURIComponent when generating the embed script, but this fails when the JSON contains '', for example in Legend URL.

Need to see how to deal with the encodeURIComponent route, as it would be the best way to avoid all kinds of mischief

@spaasis spaasis added the bug label Oct 5, 2016
@spaasis
Copy link
Owner Author

spaasis commented Oct 5, 2016

Got the encodeURIComponent to work (the original issue was with parsing URL parameters). However, another issue is that the URL max length will limit this functionality pretty heavily.

The best way to embed is still to point to a hosted URL

@spaasis spaasis closed this as completed Oct 5, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant