-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Roslibjs logging 211 #299
Merged
Merged
Roslibjs logging 211 #299
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
c5d7c29
[#211] Add js logging functions
joshua-glazer eae6172
[#211] Add timestamps to log messages
joshua-glazer 3e7b2c5
[#211] Fix typo
joshua-glazer 31bc68b
[#211] Refactor timestamp calculations
joshua-glazer d2e920d
[#211] Replace time in seconds with hh:mm:ss format for gui console
joshua-glazer 81adb32
[#211] Adjust comments, remove todos, rename logGeneric
joshua-glazer 9c46742
[#211] Minor refactor timestamp function
joshua-glazer 3a985b8
[#211] Refactor code to make it cleaner
joshua-glazer 7517562
[#211] Fix recommended changes by smartens
joshua-glazer 0ab21c3
[#211] Remove useless console.log
MartensCedric 57ade01
[#211] Adjust code based on Peter's request
joshua-glazer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When adding any new function good practice is to add a docstring for it.
Please add a high level overview of what each function does, in a sentence or two.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@PeterGhimself It looks like I did add a docstring. Did I do it right?