Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protocol Handlers For Robust Toolbox? #85

Open
LudwigVonChesterfield opened this issue Apr 8, 2023 · 4 comments · May be fixed by #136
Open

Protocol Handlers For Robust Toolbox? #85

LudwigVonChesterfield opened this issue Apr 8, 2023 · 4 comments · May be fixed by #136

Comments

@LudwigVonChesterfield
Copy link

I mean, ss14 already uses a ss14:// preffix. It would be neat to be able to connect directly by giving your friend a link.

@PJB3005 PJB3005 transferred this issue from space-wizards/RobustToolbox Apr 8, 2023
@PJB3005
Copy link
Member

PJB3005 commented Apr 8, 2023

The launcher can handle this, but the problem is actually installing the protocol handlers.

Our launcher distribution options right now are:

  1. Steam
  2. Zip download
  3. Linux Flatpak

Some notes on this:
Windows Steam: doable, but I need to get around to adding an install script that wires up the relevant registry keys.
Windows zip: would require UAC prompt to install handlers, and leave behind registry keys that can't be cleared up correctly. Yuck.
macOS: I assume/hope that we just need to declare this in the app manifest somewhere so macOS picks up on it automatically if you drop the app bundle in ~/Applications.
Steam macOS: no idea since I assume the above of ~/Applications won't apply.
Linux zip or Steam: well it wouldn't require a UAC prompt like Windows but we'd still be leaving garbage behind.
Linux flatpak: probably doable.

@ike709
Copy link
Contributor

ike709 commented Apr 8, 2023

For the scenarios that would leave junk behind, maybe just prompt the user on first run and ask if they want to install the handler?

@PJB3005
Copy link
Member

PJB3005 commented Apr 8, 2023

For the scenarios that would leave junk behind, maybe just prompt the user on first run and ask if they want to install the handler?

Something like that is basically unavoidable for zip downloads, so it's probably better than nothing yes. May be better to just have a button in the options though.

@Visne
Copy link
Member

Visne commented Jul 6, 2023

For cleaning up the junk, there could be a button in the settings to undo the handler installation. Then people that care have the option to remove it, at least. I think 99% of users won't care or even notice, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants