Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some entities ids is camelCase #29097

Open
lzk228 opened this issue Jun 16, 2024 · 3 comments
Open

some entities ids is camelCase #29097

lzk228 opened this issue Jun 16, 2024 · 3 comments
Labels
Status: Untriaged Somebody go through and give this appropriate labels

Comments

@lzk228
Copy link
Contributor

lzk228 commented Jun 16, 2024

it should be PascalCase

@github-actions github-actions bot added the Status: Untriaged Somebody go through and give this appropriate labels label Jun 16, 2024
@MrMothman
Copy link

Hello, I am a first time contributor of ss14 and I am going to take a crack at fixing this

@MrMothman
Copy link

This shouldn't affect behavior Id: correct? there are quite a few of those that are off, I also noticed that in EntityLists/ all of those also don't have pascal is that something we would like to fix as well? I am just making sure how global we want this change to be before I start do them all. I also noticed all dice dont have it and clinetsideclone.yml. and a lot of behavior id: on top of the specific storage sections ones. I just did this form the root of entities/ if you want the same list I'm looking at "find . -type f -name "*.yml" -exec grep -H -E 'id: [a-z]' {} +"

@MrMothman
Copy link

I made a judgement call PR is here: #29117

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Untriaged Somebody go through and give this appropriate labels
Projects
None yet
Development

No branches or pull requests

2 participants