-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 29097: adjusted ids in entities and entitylist to be PascalCase #29117
base: master
Are you sure you want to change the base?
Issue 29097: adjusted ids in entities and entitylist to be PascalCase #29117
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you also need to change the names of all the relationships to the changed entities.
to give you an example:
https://github.com/search?q=repo%3Aspace-wizards%2Fspace-station-14%20clientsideclone&type=code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also you need to put all changed entities' ids in /Resources/migration.yml
this also doesnt account for the few ids with _ in them |
Thank you I assumed it was somewhere else as well @lzk228 @TheShuEd : ) @deltanedas all the ones with _ in the name are behavior Ids: and i didn't know if we also wanted those changed. I didn't do behavior ids: or the dice_bag.yml because those were pretty weird and i didn't know if their was a reason. |
ok leave it as it is for now, just do what i and Ed said |
i ran find . -type f -exec grep -H -f p.txt {} + > FilesToAdjust.txt |
you dont need to change maps if you write all changes in migration.yml |
ahhh the more you learn then. I am sorry about that |
you still need to add changes to the migration because the forks have their maps still using those items. Forcing ALL projects to rewrite these changes manually is a very bad idea. |
I got that sorry I also had to figure out the error that was caused when I changed the entityList .ymls. I am going to go track down where I accidentally changed the sprite load. |
One day later and I got all the checks: ) |
Ed tfym approved |
|
||
|
||
|
||
|
||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove those extra lines
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
About the PR
I adjusted files inside of entities and entitylist so that the ids: feild is all in pascal case: the entities list is below
./Markers/clientsideclone.yml: id: clientsideclone
./Markers/construction_ghost.yml: id: constructionghost
./Markers/drag_shadow.yml: id: dragshadow
./Markers/hover_entity.yml: id: hoverentity
./Objects/Fun/dice.yml: id: d20Dice
./Objects/Fun/dice.yml: id: d12Dice
./Objects/Fun/dice.yml: id: d10Dice
./Objects/Fun/dice.yml: id: d8Dice
./Objects/Fun/dice.yml: id: d6Dice
./Objects/Fun/dice.yml: id: d4Dice
./Structures/hydro_tray.yml: id: hydroponicsTray
./Structures/Machines/Computers/computers.yml: id: computerBodyScanner
./Structures/soil.yml: id: hydroponicsSoil
./Structures/Storage/filing_cabinets.yml: id: filingCabinet
./Structures/Storage/filing_cabinets.yml: id: filingCabinetTall
./Structures/Storage/filing_cabinets.yml: id: filingCabinetDrawer
./Structures/Storage/filing_cabinets.yml: id: filingCabinetRandom
./Structures/Storage/filing_cabinets.yml: id: filingCabinetTallRandom
./Structures/Storage/filing_cabinets.yml: id: filingCabinetDrawerRandom
./Objects/Tools/t-ray.yml: id: trayScanner
Along with the above I also changed all occurrences of those ids: in files where they were called
Why / Balance
#28693
Also, I found this to be an easier task and want to get use to working within this project before I take on bigger projects.
Also, Cases matter to keep the same:
NOTE: I didn't changed dice_bag.yml or any behavior ids:, I'm not sure if we want to change those but if we do It is an easy fix.
Technical details
Media
Breaking changes
Changelog