Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing hands unwields item #28161

Merged
merged 1 commit into from
May 26, 2024
Merged

Conversation

Errant-4
Copy link
Contributor

About the PR

Guns are being changed to no longer unwield when Use Item In Hand is pressed #28002. The next best way to unwield an item is to switch to the other hand and press Drop. This change just makes it so the item unwields when you change hands, no need to also press Drop. I can't think of a plausible reason anyone would change hands while wielding an item except to use the second hand for something else

Why / Balance

QOL, saves one pointless keypress, hopefully more intuitive to those who did not already know you can "drop" the second hand to unwield

Media

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog
🆑 Errant

  • tweak: Changing hands while wielding an item will now immediately unwield it.

@Plykiya
Copy link
Contributor

Plykiya commented May 23, 2024

wouldn't it also be useful to wield the thing automatically if you change hands to it with a free hand? although someone else suggested it would be more ideal for wieldable things to be treated as wielded automatically if you ever have a free hand rather than it taking up an action... eh, probably out of scope

@EmoGarbage404
Copy link
Member

yeah i think this is fine. if its cbt then just revert

@EmoGarbage404 EmoGarbage404 merged commit 6574c9b into space-wizards:master May 26, 2024
12 checks passed
@Errant-4 Errant-4 deleted the unwield branch May 26, 2024 05:43
rbertoche pushed a commit to rbertoche/space-station-14 that referenced this pull request Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants