Add ability to add additional friendly and hostile factions in prototypes #29636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lzk228
changed the title
github-actions
bot
added
the
Status: Needs Review
lzk228
changed the title
|
Hm, I don't think this is the right way to do this. Those fields look like they're meant to be temporary caches of friendly/hostile factions calculated from the factions the entity belongs to. They shouldn't be used to manually set the factions for an individual entity. I would think you could make a new faction for the entity that has those relationships set up. If that's not possible, you could probably add two extra fields to the component (like additionalFriends, additionalEnemies or something) that are DataFields, and have those get unioned into the calculation when it updates the caches. |
lzk228
changed the title
Tayrtahn
approved these changes
Jul 1, 2024
aspiringLich
pushed a commit
to aspiringLich/space-station-14
that referenced
this pull request
Jul 21, 2024
…ypes (space-wizards#29636) * Make friendly and hostile factions in NpcFactionMemberComponent datafiels **
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
title
Why / Balance
i need this in fork