Fix AtmosDeviceSystem debug assert Heisenbug #29752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Status: Needs Review
|
Thanks for investigating, fixing it, and testing it! I'm going to need to take some time to understand the issue and fix, but if someone else is confident and understands what's going on please go ahead and merge this. |
|
Yeah, by all means do take your time with this. My understanding of the atmos system is pretty minimal, so there very well could be a better fix for this! |
|
Option A I comment out vgroid (which I'm not against). If anyone wants me to take option A let me know. |
Callmore
pushed a commit
to Callmore/space-station-14
that referenced
this pull request
Jul 14, 2024
Fix AtmosDeviceSystem debug assertion Heisenbug
aspiringLich
pushed a commit
to aspiringLich/space-station-14
that referenced
this pull request
Jul 21, 2024
Fix AtmosDeviceSystem debug assertion Heisenbug
themias
pushed a commit
to themias/space-station-14
that referenced
this pull request
Aug 9, 2024
Fix AtmosDeviceSystem debug assertion Heisenbug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Kills the pesky debug assert that sometimes triggers on certain integration tests.
Why / Balance
Fixes #28908.
Technical details
The assertion is triggered when an atmos device that is being tracked as off-grid (more accurately, on a grid that doesn't have an atmosphere) is updated and turns out to actually be on-grid (a grid with an atmosphere). There are a few ways this can happen, with grid splitting, automatic atmosphere addition when a grid is big enough, and possibly more.
The assertion is replaced by code to gracefully handle the issue by making the device try to RejoinAtmosphere and get properly tracked.
The PR includes a test that reproduces the error with the current master and passes with the changes from this PR. A method was added to AtmosDeviceSystem to check whether a given entity is considered off-grid.
Media
Code.
Breaking changes
Changelog
Nah.