-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unit for barometer is wrong (hPA instead of hPa) (rev. 13) #2
Comments
I just crawled the entire directory. Right now a single space is providing barometer data: |
Hi, maybe we could simplify the sensors. Because now it's almost always an array of objet with value, unit, location, and desc. We could write the specs so its' backward compatible with the detailed sensors, and remove them all, so people can add their own sensors. And still provide examples of sensors. |
Hm, I think some of the sensors should be standardized, e.g. people now present. But simplification might be an option. |
I have no clue how the specification is handled. For v13 it might be an option to just add "hPa" as enum value in addition to "hPA", and then drop "hPA" in v14. That way it is possible for hackspaces (our hackspace in Siegen actually provides a barometric value of "null" - grgh) to deliver the sensor value correctly without breaking the other hackspaces. |
I think it would be a breaking change. What do you think @HackerspaceKRK @simon-budig ? |
We don't know whether there are other applications that will consider See #3 for v0.14 discussion. @simon-budig what do you think? :) |
This issues is about to be resolved in #7. Please comment there. |
The unit for the "barometer" device is wrongly capitalized, it should be "hPa" instead of "hPA" (see https://en.wikipedia.org/wiki/Pascal_%28unit%29 )
The text was updated successfully, but these errors were encountered: