JP-3499: Handle too much masked data for NIRISS SOSS extractions in extract_1d #8265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #8265 +/- ##
==========================================
- Coverage 75.20% 75.15% -0.06%
==========================================
Files 470 470
Lines 38578 38604 +26
==========================================
Hits 29013 29013
- Misses 9565 9591 +26
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
hbushouse
changed the title
…cetelescope#8225) Co-authored-by: Ned Molter <emolter@stsci.edu> Co-authored-by: Howard Bushouse <bushouse@stsci.edu>
…#8187) Co-authored-by: Howard Bushouse <bushouse@stsci.edu>
github-actions
bot
added
photom
pipeline
resample
testing
spec2 pipeline
documentation
residual_fringe
labels
hbushouse
reviewed
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves JP-3499
Closes #8166
This PR addresses a bug that would cause a cryptic ValueError traceback inside the SOSS ATOCA 1-d spectrum extraction for only a few specific integrations out of many on a given target. Bug occurs when the jump step flags the majority of the detector in that integration, such that no valid data exist in the order 2 region. The PR checks for too little overlap between order 2 wavelength space and valid data, and if this is the case, sets all flux values in order 2 to NaN.
Checklist for maintainers
CHANGES.rstwithin the relevant release sectionHow to run regression tests on a PR
Jenkins run links full run here ; fixed deploy truthfile, no code changes. soss tests only