Provide no caching for the data #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #72 +/- ##
=========================================
Coverage ? 82.49%
=========================================
Files ? 18
Lines ? 514
Branches ? 0
=========================================
Hits ? 424
Misses ? 90
Partials ? 0
Continue to review full report at Codecov.
|
shanaxel42
approved these changes
Oct 4, 2018
ttung
force-pushed
the
tonytung-reentrant-contextmanager
branch
from
6cdce2c
to
2dcbc22
Compare
ttung
force-pushed
the
tonytung-no-caching
branch
from
3849dbc
to
0ef5f52
Compare
ttung
force-pushed
the
tonytung-reentrant-contextmanager
branch
from
2dcbc22
to
816c593
Compare
ttung
force-pushed
the
tonytung-no-caching
branch
from
0ef5f52
to
445513d
Compare
ttung
force-pushed
the
tonytung-reentrant-contextmanager
branch
from
816c593
to
fb34c86
Compare
ttung
force-pushed
the
tonytung-no-caching
branch
from
445513d
to
e2a64bc
Compare
Tiles can be read multiple times, but each time it decodes from the backend. The application is responsbile for caching it if necessary. Test plan: make -j test
ttung
changed the base branch from
tonytung-reentrant-contextmanager
to
master
ttung
force-pushed
the
tonytung-no-caching
branch
from
e2a64bc
to
f3c140a
Compare
ttung
pushed a commit
that referenced
this pull request
Oct 10, 2018
If the tile_shape is not provided by the json file, we should infer it from the actual data. This is a suboptimal data path since it requires a decoding step just to get the shape of the tile, so we warn about it. Previously, this field was set by `_load()`, but that was removed in #72. Test plan: Generate a tileset document, and then strip the shape data from the tiles. Then read it back. The correct tile shapes should be provided, but getting them should trigger a warning.
ttung
added a commit
that referenced
this pull request
Oct 10, 2018
If the tile_shape is not provided by the json file, we should infer it from the actual data. This is a suboptimal data path since it requires a decoding step just to get the shape of the tile, so we warn about it. Previously, this field was set by `_load()`, but that was removed in #72. Test plan: Generate a tileset document, and then strip the shape data from the tiles. Then read it back. The correct tile shapes should be provided, but getting them should trigger a warning.
ttung
pushed a commit
to spacetx/starfish
that referenced
this pull request
Oct 10, 2018
Both notebooks had datasets where the tile shapes were not consistently provided. spacetx/slicedimage#72 broke the recording of the tile shape, and spacetx/slicedimage#73 fixes it. Test plan: `make -j run__notebooks/py/ISS_Pipeline_-_Breast_-_1_FOV.py run__notebooks/py/assay_comparison.py`
ttung
added a commit
to spacetx/starfish
that referenced
this pull request
Oct 11, 2018
Both notebooks had datasets where the tile shapes were not consistently provided. spacetx/slicedimage#72 broke the recording of the tile shape, and spacetx/slicedimage#73 fixes it. Test plan: `make -j run__notebooks/py/ISS_Pipeline_-_Breast_-_1_FOV.py run__notebooks/py/assay_comparison.py`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tiles can be read multiple times, but each time it decodes from the backend. The application is responsbile for caching it if necessary.
Depends on #71
Test plan: make -j test