Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write a payment provider plugin for pretix to accept ETH #30

Closed
bmann opened this issue Jan 9, 2019 · 23 comments
Closed

Write a payment provider plugin for pretix to accept ETH #30

bmann opened this issue Jan 9, 2019 · 23 comments
Labels
bounty Payment option available community Community activities

Comments

@bmann
Copy link
Member

bmann commented Jan 9, 2019

From discussions at EthMagicians we're going to be using pretix to run registration for Council of Paris 2019.

For now, we're going to use the fully hosted version and use their manual payment system to instruct people to donate to the EthMagicians wallet --> https://donations.ethereum-magicians.org.

For future events, it would be great to run our own instance -- e.g. tickets.ethereumevents.global -- that has an ETH payment provider plugin installed. There will be a separate issue for doing the initial install and some maintenance.

pretix is written in Django and has good instructions on how to write a payment provider. The Bitpay payment provider plugin may prove helpful to refer to.

The initial scope will be:

  • support ETH
  • support DAI new
  • display a configured event wallet address
  • watch for an incoming payment linked to the order
  • communicate back the successful transaction to indicate that the order is paid

Aside from building the feature, the bounty builder will be responsible for

  • creating a Github repo
  • releasing the code under Apache 2.0

Future feature requests and additional bounties will be listed in the new repo for this payment provider plugin. Feel free to use this thread to brainstorm future features (e.g. DAI and arbitrary ERC20 token support, NFT "tickets", etc.).

Update

The MakerDAO team have stepped up with a 500DAI bounty, to include DAI in the initial release.

@bmann bmann added bounty Payment option available community Community activities labels Jan 9, 2019
@bmann
Copy link
Member Author

bmann commented Jan 9, 2019

Here's a link to our Discord pretix channel if you'd like to chat live https://discord.gg/S7vVpfn

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


This issue now has a funding of 0.25 ETH (33.56 USD @ $134.23/ETH) attached to it as part of the EthMagicians fund.

@swapnildey94
Copy link

Interested - Familiar with Python and integrating Payment gateways related to blockchain. Have integrated similar platforms in other projects.

Unable to apply through gitcoin.

@bmann
Copy link
Member Author

bmann commented Jan 16, 2019

@techswappy oh, what’s the issue with Gitcoin? Let me know what problems you’re having.

@swapnildey94
Copy link

@bmann I think they have a restriction on how many issues you can apply to (i used up my 3 issues) before I stumbled upon this work.

@gitcoinbot
Copy link

gitcoinbot commented Feb 2, 2019

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work has been started.

These users each claimed they can complete the work by 9 months, 2 weeks from now.
Please review their action plans below:

1) uivlis has applied to start work (Funders only: approve worker | reject worker).

Let me try this one out, even though I can't guarantee NFT tickets right from the start.

Learn more on the Gitcoin Issue Details page.

2) vic-en has been approved to start work.

I can pretty much get this done in 2 weeks max. Firstly, I'll clone the pretix repo and install on my server to ensure I have a working installation. I'll then proceed to develop an API compatible with ETH using the official doc and bitpay code as reference. After the code is done, I'll test on initial server and test on another server to ensure I don't miss anything out.

Learn more on the Gitcoin Issue Details page.

@gitcoinbot
Copy link

💰 A crowdfund contribution worth 500.00000 DAI (500.0 USD @ $1.0/DAI) has been attached to this funded issue from @nanexcool.💰

Want to chip in also? Add your own contribution here.

@uivlis
Copy link

uivlis commented Feb 19, 2019

Hi @bmann! Just to know, is the bounty still active? If it is, I kindly suggest you pick somebody to work on it. The application to work on this bounty is stopping me from completing other bounties since one can only work on 3 at most.

@nanexcool
Copy link

Hey, I just want to add that the 500 Dai bounty that I added is to also include Dai as a payment method, in addition to ETH. I don't think this is reflected yet in the description.

@bmann
Copy link
Member Author

bmann commented Feb 23, 2019

@uivlis sorry about that, getting used to how Gitcoin works. It is still active. There are some people who are already working on code outside of Gitcoin, so I'm unclear how to handle this. I may need to make this an "open" bounty and go from there.

@bmann
Copy link
Member Author

bmann commented Feb 26, 2019

@vic-en has provided me with a demo link through chat, see https://github.com/vic-en/pretix-eth-payment-plugin for further development

@gitcoinbot
Copy link

@vic-en Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@bmann
Copy link
Member Author

bmann commented Mar 1, 2019

Working on this in a separate repo, so snoozing.

@gitcoinbot
Copy link

@vic-en Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

1 similar comment
@gitcoinbot
Copy link

@vic-en Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@bmann
Copy link
Member Author

bmann commented Mar 3, 2019

I have attempted to snooze Gitcoin Bot for 10 days :)

@vic-en
Copy link

vic-en commented Mar 4, 2019

Work in progress.

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work for 0.25 ETH (35.4 USD @ $141.6/ETH) has been submitted by:

  1. @vic-en

@bmann please take a look at the submitted work:


@vic-en
Copy link

vic-en commented Mar 26, 2019

Hi @bmann , can you kindly review the project so the fund can be released soon? I've been waiting for a response on discord for days now. Thanks in anticipation.

@gitcoinbot
Copy link

⚡️ A tip worth 0.05000 ETH (6.89 USD @ $137.9/ETH) has been granted to @vic-en for this issue from @bmann. ⚡️

Nice work @vic-en! To redeem your tip, login to Gitcoin at https://gitcoin.co/explorer and select 'Claim Tip' from dropdown menu in the top right, or check your email for a link to the tip redemption page.

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


The funding of 0.25 ETH (34.47 USD @ $137.9/ETH) (plus a crowdfund of 500.0 DAI worth 500.0 USD) attached to this issue has been approved & issued to @vic-en.

Thanks to @nanexcool, @nanexcool for their crowdfunded contributions to this bounty.

Additional Tips for this Bounty:

  • bmann tipped 0.0500 ETH worth 6.89 USD to vic-en.

@bmann bmann closed this as completed Apr 17, 2019
@ligi
Copy link

ligi commented May 17, 2019

did anyone try the PR? I just tried it out and am getting:
vic-en/pretix-eth-payment-plugin#11

@bmann
Copy link
Member Author

bmann commented May 17, 2019

@ligi I don’t have time to clean this up right now but my intent is to fork and get it done in a repo I maintain. Thanks for filing those issues - they are a good starting point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bounty Payment option available community Community activities
Projects
None yet
Development

No branches or pull requests

7 participants