Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple Z - Levels - Quality of Life #14

Closed
Xoxeyos opened this issue Oct 22, 2019 · 4 comments
Closed

Multiple Z - Levels - Quality of Life #14

Xoxeyos opened this issue Oct 22, 2019 · 4 comments
Labels
enhancement New feature or request

Comments

@Xoxeyos
Copy link

Xoxeyos commented Oct 22, 2019

There isn't support for multi - Z levels.

@SpaiR
Copy link
Owner

SpaiR commented Oct 22, 2019

Actually, absence of multi-z support is a design decision. I've described my motivation about that under the Disclaimer! label in project readme. But I'm open to hear arguments why it's important to have it.

@Crossedfall
Copy link

The simplest reason is that they're becoming more common. I also don't see much credence in saying that they are, "unmaintainable from the perspective of Open Source contribution." Considering that the codebases which are using Multi-Z maps have consistent contributions, I'd say it's pretty maintainable.

@SpaiR
Copy link
Owner

SpaiR commented Nov 2, 2019

I have my own experience as a ss13 dev and I've met situations when it's become pretty painful to deal with conflicts based on multi-z maps. And here we have the Eris codebase. They have multi-z station map too. And they’ve already been in situations when they should to freeze all map changes because of changes on one layer. For me that's enough to think so.

But I understand your point too. Right now I'm in a process of rewriting of the editor, so I will consider about that feature.

@monster860
Copy link

The thing about multi-z stations is that the whole station is one single unit. With things like, cent-comm and station being on different z-levels, yeah that should be on different files. However, when you have a single station with multiple floors and they are linked to each other, and where moving tiles around on one layer might cause problems on the upper layer, they should absolutely be the same file.

Anyways, the only thing preventing using multiz in the map editor does is screw over any one who wants to contribute to a codebase that has multiz maps.

@SpaiR SpaiR added the enhancement New feature or request label Apr 5, 2020
@SpaiR SpaiR closed this as completed in 56d98fc Apr 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants