Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add QueryParams to WebSocket #886

Merged
merged 6 commits into from
Jul 9, 2024

Conversation

VishnuSanal
Copy link
Contributor

Description

This PR fixes #526

Copy link

vercel bot commented Jul 8, 2024

@VishnuSanal is attempting to deploy a commit to the sparckles Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

codspeed-hq bot commented Jul 9, 2024

CodSpeed Performance Report

Merging #886 will not alter performance

Comparing VishnuSanal:feat/add-ws-query-params (e80b1ad) with main (58e724d)

Summary

✅ 110 untouched benchmarks

@VishnuSanal VishnuSanal marked this pull request as ready for review July 9, 2024 13:40
@sansyrox
Copy link
Member

sansyrox commented Jul 9, 2024

The PR looks great! Just one update before we merge this 😄

@VishnuSanal VishnuSanal requested a review from sansyrox July 9, 2024 14:55
Copy link

vercel bot commented Jul 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
robyn ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 9, 2024 4:13pm

Copy link
Member

@sansyrox sansyrox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍 Great work

@sansyrox sansyrox merged commit 24715f1 into sparckles:main Jul 9, 2024
60 checks passed
@VishnuSanal VishnuSanal deleted the feat/add-ws-query-params branch July 10, 2024 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add query params in Websockets
2 participants