Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delta patches do not apply if source files that need to be diffed are not writeable #2211

Closed
zorgiepoo opened this issue Jul 20, 2022 · 0 comments · Fixed by #2216
Closed
Milestone

Comments

@zorgiepoo
Copy link
Member

zorgiepoo commented Jul 20, 2022

From discussion #2210, if files in the source app bundle are not writeable and we copy the app bundle and do bspatch() on one of the files, it will fail if the destination file is not writable. At first I thought this wasn't worth fixing but I think this is easier to fix than I originally thought. In this case if the file is not writeable we can enter a code path we already have for copying new permissions and using a new fresh file.

@zorgiepoo zorgiepoo added this to the 2.3 milestone Jul 20, 2022
@zorgiepoo zorgiepoo changed the title Delta patches to not apply if source files that need to be diffed are not writeable Delta patches do not apply if source files that need to be diffed are not writeable Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant